chrome/browser/mac/keystone_registration.mm - Issue 1769703002: Add viewing of error messages from Keystone upon self-update failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/mac/keystone_registration.mm

Issue 1769703002: Add viewing of error messages from Keystone upon self-update failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Display errors on status==FAILED, not !message.empty() Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/mac/keystone_registration.h ('k') | chrome/browser/ui/webui/help/version_updater_mac.mm » ('j') | chrome/browser/ui/webui/help/version_updater_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/mac/keystone_registration.mm

diff --git a/chrome/browser/mac/keystone_registration.mm b/chrome/browser/mac/keystone_registration.mm

index 82e26599cd50de8fbb426d3b9a05c677d461ef69..4ff70c35d73c8de1f48d199e96d7ce4ec253f84e 100644

--- a/chrome/browser/mac/keystone_registration.mm

+++ b/chrome/browser/mac/keystone_registration.mm

@@ -31,6 +31,8 @@ NSString* KSRegistrationCheckForUpdateNotification =

@"KSRegistrationCheckForUpdateNotification";

NSString* KSRegistrationStatusKey = @"Status";

NSString* KSRegistrationUpdateCheckErrorKey = @"Error";

+NSString* KSRegistrationUpdateCheckRawResultsKey = @"RawResults";

+NSString* KSRegistrationUpdateCheckRawErrorMessagesKey = @"RawErrorMessages";

NSString* KSRegistrationStartUpdateNotification =

@"KSRegistrationStartUpdateNotification";