TextIteratorAlgorithm should not force layout update in constructor.

TextIteratorAlgorithm should not force layout update in constructor.

Asking to update layout should not be done at this level.
Updating layout is part of the document/view lifecycle
and should be coordinated at a higher level
than an iterator constructor.

Thus, move calling Document::updateLayoutIgnorePendingStylesheets up
to the callsites of the TextIterator constructor.
These callsites should be audited and moved up
even farther up the call stack.

This is a re-land of https://crrev.com/4ed5e3b54598950731022926b09fdc8742abea74.

BUG=590295
R=esprehn

Committed: https://crrev.com/3576860f06d835f699521bccbb134b65d7326dca
Cr-Commit-Position: refs/heads/master@{#379408}

[dglazkov, 2016-03-04 22:26:55]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 22:27:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1769683002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1769683002/1

[dglazkov, 2016-03-04 22:28:41]

Description was changed from

==========
Rebased.

BUG=
==========

to

==========
TextIteratorAlgorithm should not force layout update in constructor.

Asking to update layout should not be done at this level -- updating layout is
part of the document/view lifecycle and should be coordinated at a higher level
than an iterator constructor.

Thus, move calling Document::updateLayoutIgnorePendingStylesheets up to the
callsites of the TextIterator constructor. These callsites should be audited and
moved up even farther up the call stack.

This is a re-land of https://crrev.com/4ed5e3b54598950731022926b09fdc8742abea74.

BUG=590295
R=esprehn
==========

[dglazkov, 2016-03-04 22:28:41]

dglazkov@chromium.org changed reviewers:
+ esprehn@chromium.org

[ojan, 2016-03-04 22:34:57]

ojan@chromium.org changed reviewers:
+ ojan@chromium.org

[ojan, 2016-03-04 22:34:58]

lgtm

[esprehn, 2016-03-04 22:53:51]

lgtm

[dglazkov, 2016-03-04 23:02:05]

Description was changed from

==========
TextIteratorAlgorithm should not force layout update in constructor.

Asking to update layout should not be done at this level -- updating layout is
part of the document/view lifecycle and should be coordinated at a higher level
than an iterator constructor.

Thus, move calling Document::updateLayoutIgnorePendingStylesheets up to the
callsites of the TextIterator constructor. These callsites should be audited and
moved up even farther up the call stack.

This is a re-land of https://crrev.com/4ed5e3b54598950731022926b09fdc8742abea74.

BUG=590295
R=esprehn
==========

to

==========
TextIteratorAlgorithm should not force layout update in constructor.

Asking to update layout should not be done at this level.
Updating layout is part of the document/view lifecycle
and should be coordinated at a higher level
than an iterator constructor.

Thus, move calling Document::updateLayoutIgnorePendingStylesheets up
to the callsites of the TextIterator constructor.
These callsites should be audited and moved up
even farther up the call stack.

This is a re-land of https://crrev.com/4ed5e3b54598950731022926b09fdc8742abea74.

BUG=590295
R=esprehn
==========

[commit-bot: I haz the power, 2016-03-05 00:10:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-05 00:10:25]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2016-03-05 00:10:49]

The CQ bit was checked by dglazkov@chromium.org

[commit-bot: I haz the power, 2016-03-05 00:11:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1769683002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1769683002/1

[commit-bot: I haz the power, 2016-03-05 00:19:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-05 00:21:03]

Description was changed from

==========
TextIteratorAlgorithm should not force layout update in constructor.

Asking to update layout should not be done at this level.
Updating layout is part of the document/view lifecycle
and should be coordinated at a higher level
than an iterator constructor.

Thus, move calling Document::updateLayoutIgnorePendingStylesheets up
to the callsites of the TextIterator constructor.
These callsites should be audited and moved up
even farther up the call stack.

This is a re-land of https://crrev.com/4ed5e3b54598950731022926b09fdc8742abea74.

BUG=590295
R=esprehn
==========

to

==========
TextIteratorAlgorithm should not force layout update in constructor.

Asking to update layout should not be done at this level.
Updating layout is part of the document/view lifecycle
and should be coordinated at a higher level
than an iterator constructor.

Thus, move calling Document::updateLayoutIgnorePendingStylesheets up
to the callsites of the TextIterator constructor.
These callsites should be audited and moved up
even farther up the call stack.

This is a re-land of https://crrev.com/4ed5e3b54598950731022926b09fdc8742abea74.

BUG=590295
R=esprehn

Committed: https://crrev.com/3576860f06d835f699521bccbb134b65d7326dca
Cr-Commit-Position: refs/heads/master@{#379408}
==========

[commit-bot: I haz the power, 2016-03-05 00:21:04]

Patchset 1 (id:??) landed as
https://crrev.com/3576860f06d835f699521bccbb134b65d7326dca
Cr-Commit-Position: refs/heads/master@{#379408}

[dglazkov, 2016-03-08 02:31:59]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1772223002/ by dglazkov@chromium.org.

The reason for reverting is: Caused several fun crashes and security bugs..