Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h - Issue 176963017: Remove WrapperWorldType from V8 binding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h

Issue 176963017: Remove WrapperWorldType from V8 binding (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfacePython3.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h

diff --git a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h

index 1ff4cb37c6790d807bdc1fd14fade31d261b357f..a8cd66536fa2f705159ad49786a63353bb14dbec 100644

--- a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h

+++ b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h

@@ -46,7 +46,7 @@ class V8TestInterfaceWillBeGarbageCollected {

public:

static bool hasInstance(v8::Handle<v8::Value>, v8::Isolate*);

static v8::Handle<v8::Object> findInstanceInPrototypeChain(v8::Handle<v8::Value>, v8::Isolate*);

- static v8::Handle<v8::FunctionTemplate> domTemplate(v8::Isolate*, WrapperWorldType);

+ static v8::Handle<v8::FunctionTemplate> domTemplate(v8::Isolate*);

static TestInterfaceWillBeGarbageCollected* toNative(v8::Handle<v8::Object> object)

{

return fromInternalPointer(object->GetAlignedPointerFromInternalField(v8DOMWrapperObjectIndex));

@@ -109,7 +109,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestInterfaceWill

template<typename CallbackInfo>

inline void v8SetReturnValueForMainWorld(const CallbackInfo& callbackInfo, TestInterfaceWillBeGarbageCollected* impl)

{

- ASSERT(worldType(callbackInfo.GetIsolate()) == MainWorld);

+ ASSERT(DOMWrapperWorld::current(callbackInfo.GetIsolate())->isMainWorld());

if (UNLIKELY(!impl)) {

v8SetReturnValueNull(callbackInfo);

return;