Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: Source/bindings/v8/V8DOMWrapper.cpp

Issue 176963017: Remove WrapperWorldType from V8 binding (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/V8DOMConfiguration.cpp ('k') | Source/bindings/v8/V8ErrorHandler.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 26 matching lines...) Expand all
37 #include "bindings/v8/V8Binding.h" 37 #include "bindings/v8/V8Binding.h"
38 #include "bindings/v8/V8ObjectConstructor.h" 38 #include "bindings/v8/V8ObjectConstructor.h"
39 #include "bindings/v8/V8PerContextData.h" 39 #include "bindings/v8/V8PerContextData.h"
40 #include "bindings/v8/V8ScriptRunner.h" 40 #include "bindings/v8/V8ScriptRunner.h"
41 41
42 namespace WebCore { 42 namespace WebCore {
43 43
44 static v8::Local<v8::Object> wrapInShadowTemplate(v8::Local<v8::Object> wrapper, Node* impl, v8::Isolate* isolate) 44 static v8::Local<v8::Object> wrapInShadowTemplate(v8::Local<v8::Object> wrapper, Node* impl, v8::Isolate* isolate)
45 { 45 {
46 static int shadowTemplateKey; // This address is used for a key to look up t he dom template. 46 static int shadowTemplateKey; // This address is used for a key to look up t he dom template.
47 WrapperWorldType currentWorldType = worldType(isolate);
48 V8PerIsolateData* data = V8PerIsolateData::from(isolate); 47 V8PerIsolateData* data = V8PerIsolateData::from(isolate);
49 v8::Handle<v8::FunctionTemplate> shadowTemplate = data->existingDOMTemplate( currentWorldType, &shadowTemplateKey); 48 v8::Handle<v8::FunctionTemplate> shadowTemplate = data->existingDOMTemplate( &shadowTemplateKey);
50 if (shadowTemplate.IsEmpty()) { 49 if (shadowTemplate.IsEmpty()) {
51 shadowTemplate = v8::FunctionTemplate::New(isolate); 50 shadowTemplate = v8::FunctionTemplate::New(isolate);
52 if (shadowTemplate.IsEmpty()) 51 if (shadowTemplate.IsEmpty())
53 return v8::Local<v8::Object>(); 52 return v8::Local<v8::Object>();
54 shadowTemplate->SetClassName(v8AtomicString(isolate, "HTMLDocument")); 53 shadowTemplate->SetClassName(v8AtomicString(isolate, "HTMLDocument"));
55 shadowTemplate->Inherit(V8HTMLDocument::domTemplate(isolate, currentWorl dType)); 54 shadowTemplate->Inherit(V8HTMLDocument::domTemplate(isolate));
56 shadowTemplate->InstanceTemplate()->SetInternalFieldCount(V8HTMLDocument ::internalFieldCount); 55 shadowTemplate->InstanceTemplate()->SetInternalFieldCount(V8HTMLDocument ::internalFieldCount);
57 data->setDOMTemplate(currentWorldType, &shadowTemplateKey, shadowTemplat e); 56 data->setDOMTemplate(&shadowTemplateKey, shadowTemplate);
58 } 57 }
59 58
60 v8::Local<v8::Function> shadowConstructor = shadowTemplate->GetFunction(); 59 v8::Local<v8::Function> shadowConstructor = shadowTemplate->GetFunction();
61 if (shadowConstructor.IsEmpty()) 60 if (shadowConstructor.IsEmpty())
62 return v8::Local<v8::Object>(); 61 return v8::Local<v8::Object>();
63 62
64 v8::Local<v8::Object> shadow = V8ScriptRunner::instantiateObject(shadowConst ructor); 63 v8::Local<v8::Object> shadow = V8ScriptRunner::instantiateObject(shadowConst ructor);
65 if (shadow.IsEmpty()) 64 if (shadow.IsEmpty())
66 return v8::Local<v8::Object>(); 65 return v8::Local<v8::Object>();
67 shadow->SetPrototype(wrapper); 66 shadow->SetPrototype(wrapper);
68 V8DOMWrapper::setNativeInfo(wrapper, &V8HTMLDocument::wrapperTypeInfo, impl) ; 67 V8DOMWrapper::setNativeInfo(wrapper, &V8HTMLDocument::wrapperTypeInfo, impl) ;
69 return shadow; 68 return shadow;
70 } 69 }
71 70
72 v8::Local<v8::Object> V8DOMWrapper::createWrapper(v8::Handle<v8::Object> creatio nContext, const WrapperTypeInfo* type, void* impl, v8::Isolate* isolate) 71 v8::Local<v8::Object> V8DOMWrapper::createWrapper(v8::Handle<v8::Object> creatio nContext, const WrapperTypeInfo* type, void* impl, v8::Isolate* isolate)
73 { 72 {
74 V8WrapperInstantiationScope scope(creationContext, isolate); 73 V8WrapperInstantiationScope scope(creationContext, isolate);
75 74
76 V8PerContextData* perContextData = V8PerContextData::from(scope.context()); 75 V8PerContextData* perContextData = V8PerContextData::from(scope.context());
77 v8::Local<v8::Object> wrapper = perContextData ? perContextData->createWrapp erFromCache(type) : V8ObjectConstructor::newInstance(type->domTemplate(isolate, worldTypeInMainThread(isolate))->GetFunction()); 76 v8::Local<v8::Object> wrapper = perContextData ? perContextData->createWrapp erFromCache(type) : V8ObjectConstructor::newInstance(type->domTemplate(isolate)- >GetFunction());
78 77
79 if (type == &V8HTMLDocument::wrapperTypeInfo && !wrapper.IsEmpty()) 78 if (type == &V8HTMLDocument::wrapperTypeInfo && !wrapper.IsEmpty())
80 wrapper = wrapInShadowTemplate(wrapper, static_cast<Node*>(impl), isolat e); 79 wrapper = wrapInShadowTemplate(wrapper, static_cast<Node*>(impl), isolat e);
81 80
82 return wrapper; 81 return wrapper;
83 } 82 }
84 83
85 bool V8DOMWrapper::isDOMWrapper(v8::Handle<v8::Value> value) 84 bool V8DOMWrapper::isDOMWrapper(v8::Handle<v8::Value> value)
86 { 85 {
87 if (value.IsEmpty() || !value->IsObject()) 86 if (value.IsEmpty() || !value->IsObject())
88 return false; 87 return false;
89 88
90 if (v8::Handle<v8::Object>::Cast(value)->InternalFieldCount() < v8DefaultWra pperInternalFieldCount) 89 if (v8::Handle<v8::Object>::Cast(value)->InternalFieldCount() < v8DefaultWra pperInternalFieldCount)
91 return false; 90 return false;
92 91
93 v8::Handle<v8::Object> wrapper = v8::Handle<v8::Object>::Cast(value); 92 v8::Handle<v8::Object> wrapper = v8::Handle<v8::Object>::Cast(value);
94 ASSERT(wrapper->GetAlignedPointerFromInternalField(v8DOMWrapperObjectIndex)) ; 93 ASSERT(wrapper->GetAlignedPointerFromInternalField(v8DOMWrapperObjectIndex)) ;
95 ASSERT(wrapper->GetAlignedPointerFromInternalField(v8DOMWrapperTypeIndex)); 94 ASSERT(wrapper->GetAlignedPointerFromInternalField(v8DOMWrapperTypeIndex));
96 95
97 const WrapperTypeInfo* typeInfo = static_cast<const WrapperTypeInfo*>(wrappe r->GetAlignedPointerFromInternalField(v8DOMWrapperTypeIndex)); 96 const WrapperTypeInfo* typeInfo = static_cast<const WrapperTypeInfo*>(wrappe r->GetAlignedPointerFromInternalField(v8DOMWrapperTypeIndex));
98 // FIXME: We should add a more strict way to check if the typeInfo is a type Info of some DOM wrapper. 97 // FIXME: We should add a more strict way to check if the typeInfo is a type Info of some DOM wrapper.
99 // Even if it's a typeInfo of Blink, it's not guaranteed that it's a typeInf o of a DOM wrapper. 98 // Even if it's a typeInfo of Blink, it's not guaranteed that it's a typeInf o of a DOM wrapper.
100 return typeInfo->ginEmbedder == gin::kEmbedderBlink; 99 return typeInfo->ginEmbedder == gin::kEmbedderBlink;
101 } 100 }
102 101
103 } // namespace WebCore 102 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8DOMConfiguration.cpp ('k') | Source/bindings/v8/V8ErrorHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698