Chromium plumbing for Screen Orientation API orientationchange events.

Chromium plumbing for Screen Orientation API orientationchange events. 

This is using RenderViewObserver::OrientationChangeEvent and dispatch 
the information down to the renderer. More will come with locking 
and unlocking abilities. 

BUG=162827
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253911

[mlamouri (slow - plz ping), 2014-02-26 11:23:16]

This is exactly the same CL as https://codereview.chromium.org/164913004/ except
for content_view_core_impl.cc were I have added a null check for
ScreenOrientationDispatcherHost.

cdn@, can you review changes related to IPC - it should be exactly the same as
what you previously LGTM'd.

jochen@, can you review the rest? Except content_view_core_impl.cc, it should be
exactly the same as what you previously LGTM'd.

[jochen (gone - plz use gerrit), 2014-02-26 15:34:16]

LGTM

can you note under which conditions the dispatcher host is NULL?

[Cris Neckar, 2014-02-26 19:39:20]

https://codereview.chromium.org/176963016/diff/20001/content/browser/screen_o...
File content/browser/screen_orientation/screen_orientation_dispatcher_host.cc
(right):

https://codereview.chromium.org/176963016/diff/20001/content/browser/screen_o...
content/browser/screen_orientation/screen_orientation_dispatcher_host.cc:17: //
TODO(mlamouri): we will handle lock and unlock requests here.
Please request IPC security review on the CL where this is implemented.

https://codereview.chromium.org/176963016/diff/20001/content/common/screen_or...
File content/common/screen_orientation_messages.h (right):

https://codereview.chromium.org/176963016/diff/20001/content/common/screen_or...
content/common/screen_orientation_messages.h:16:
IPC_ENUM_TRAITS(blink::WebScreenOrientation)
Please use IPC_ENUM_TRAITS_MAX_VALUE and IPC_ENUM_TRAITS_MIN_VALUE so that range
is validated.

[Cris Neckar, 2014-02-26 20:27:22]

On 2014/02/26 19:39:20, Cris Neckar wrote:
>
https://codereview.chromium.org/176963016/diff/20001/content/browser/screen_o...
> File content/browser/screen_orientation/screen_orientation_dispatcher_host.cc
> (right):
> 
>
https://codereview.chromium.org/176963016/diff/20001/content/browser/screen_o...
> content/browser/screen_orientation/screen_orientation_dispatcher_host.cc:17:
//
> TODO(mlamouri): we will handle lock and unlock requests here.
> Please request IPC security review on the CL where this is implemented.
> 
>
https://codereview.chromium.org/176963016/diff/20001/content/common/screen_or...
> File content/common/screen_orientation_messages.h (right):
> 
>
https://codereview.chromium.org/176963016/diff/20001/content/common/screen_or...
> content/common/screen_orientation_messages.h:16:
> IPC_ENUM_TRAITS(blink::WebScreenOrientation)
> Please use IPC_ENUM_TRAITS_MAX_VALUE and IPC_ENUM_TRAITS_MIN_VALUE so that
range
> is validated.

LGTM once that nit is addressed.

[mlamouri (slow - plz ping), 2014-02-27 09:50:35]

https://codereview.chromium.org/176963016/diff/20001/content/common/screen_or...
File content/common/screen_orientation_messages.h (right):

https://codereview.chromium.org/176963016/diff/20001/content/common/screen_or...
content/common/screen_orientation_messages.h:16:
IPC_ENUM_TRAITS(blink::WebScreenOrientation)
On 2014/02/26 19:39:20, Cris Neckar wrote:
> Please use IPC_ENUM_TRAITS_MAX_VALUE and IPC_ENUM_TRAITS_MIN_VALUE so that
range
> is validated.

I believe we discussed that for the previous patch on IRC: WebScreenOrientation
is a bit field so checking the range would not mean much. You told me on IRC
last time that in that case IPC_ENUM_TRAITS was okay.

[mlamouri (slow - plz ping), 2014-02-27 09:50:40]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-02-27 09:50:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/176963016/40001

[commit-bot: I haz the power, 2014-02-27 15:01:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-27 15:01:54]

Failed to apply patch for ipc/ipc_message_start.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ipc/ipc_message_start.h
  Hunk #1 FAILED at 95.
  1 out of 1 hunk FAILED -- saving rejects to file ipc/ipc_message_start.h.rej

Patch:       ipc/ipc_message_start.h
Index: ipc/ipc_message_start.h
diff --git a/ipc/ipc_message_start.h b/ipc/ipc_message_start.h
index
5b9c9d71da4c735b05ff2415c9729d9fe6b3befc..6923e441a57f6a9c387ec66bfe3672e403bc9170
100644
--- a/ipc/ipc_message_start.h
+++ b/ipc/ipc_message_start.h
@@ -95,6 +95,7 @@ enum IPCMessageStart {
   EmbeddedWorkerMsgStart,
   EmbeddedWorkerContextMsgStart,
   CastMsgStart,
+  ScreenOrientationMsgStart,
   LastIPCMsgStart  // Must come last.
 };

[mlamouri (slow - plz ping), 2014-02-27 15:25:30]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-02-27 15:28:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/176963016/20002

[commit-bot: I haz the power, 2014-02-27 17:04:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-27 17:04:16]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[mlamouri (slow - plz ping), 2014-02-27 17:13:28]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-02-27 17:16:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/176963016/20002

[Cris Neckar, 2014-02-27 17:19:25]

On 2014/02/27 17:16:12, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/mlamouri%40chromium.org/176963016/20002

Haha I don't think it was me on IRC as I haven't logged on in quite a while but
that makes sense. Thanks!

[commit-bot: I haz the power, 2014-02-27 20:03:13]

Change committed as 253911