runtime/vm/object.cc - Issue 176963015: Avoid creation of a handle when ssetting native fields for the first time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 176963015: Avoid creation of a handle when ssetting native fields for the first time. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

===================================================================

--- runtime/vm/object.cc (revision 33049)

+++ runtime/vm/object.cc (working copy)

@@ -11951,9 +11951,7 @@

Object& native_fields = Object::Handle(*NativeFieldsAddr());

if (native_fields.IsNull()) {

// Allocate backing storage for the native fields.

- const Class& cls = Class::Handle(clazz());

- int num_native_fields = cls.num_native_fields();

- native_fields = TypedData::New(kIntPtrCid, num_native_fields);

+ native_fields = TypedData::New(kIntPtrCid, NumNativeFields());

StorePointer(NativeFieldsAddr(), native_fields.raw());

}

intptr_t byte_offset = index * sizeof(intptr_t);

« no previous file with comments | « no previous file | no next file » | no next file with comments »