Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2092)

Issue 1769603005: Remove first_message argument from AuthenticatorFactory::Create(). (Closed)

Created:
4 years, 6 months ago by Sergey Ulanov
Modified:
4 years, 6 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove first_message argument from AuthenticatorFactory::Create(). The first_message parameter in AuthenticatorFactory::Create() is no longer used anywhere, so it can be removed. Committed: https://crrev.com/d2b8e36a3a62f83dc61f8f9a26e055631c6af22e Cr-Commit-Position: refs/heads/master@{#379592}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -31 lines) Patch
M remoting/host/pam_authorization_factory_posix.h View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/pam_authorization_factory_posix.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/authenticator.h View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/fake_authenticator.h View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/fake_authenticator.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/protocol/it2me_host_authenticator_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/it2me_host_authenticator_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/jingle_session_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
harrythebunny1025
you a lyre crys Linus I will find out
4 years, 6 months ago (2016-03-05 18:22:01 UTC) #4
harrythebunny1025
you a lyre crys Linus I will find out
4 years, 6 months ago (2016-03-05 18:22:01 UTC) #5
harrythebunny1025
you a lyre crys Linus I will find out
4 years, 6 months ago (2016-03-05 18:22:02 UTC) #6
Sergey Ulanov
4 years, 6 months ago (2016-03-07 17:29:00 UTC) #9
kelvinp
lgtm
4 years, 6 months ago (2016-03-07 17:33:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769603005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769603005/1
4 years, 6 months ago (2016-03-07 17:47:41 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-03-07 18:35:43 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-03-07 18:36:39 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2b8e36a3a62f83dc61f8f9a26e055631c6af22e
Cr-Commit-Position: refs/heads/master@{#379592}

Powered by Google App Engine
This is Rietveld 408576698