Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: media/cdm/ppapi/ppapi_cdm_adapter.cc

Issue 1769593002: Add 4 VP9 profiles to the media::VideoCodecProfile enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hevc-codec-7
Patch Set: CR feedback Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cdm/ppapi/ppapi_cdm_adapter.cc
diff --git a/media/cdm/ppapi/ppapi_cdm_adapter.cc b/media/cdm/ppapi/ppapi_cdm_adapter.cc
index d3a143a44aed157f8eee1474e0f6b74caacac6cd..dc3ad250e768487b4b26590abbdc7a7e75096374 100644
--- a/media/cdm/ppapi/ppapi_cdm_adapter.cc
+++ b/media/cdm/ppapi/ppapi_cdm_adapter.cc
@@ -196,6 +196,15 @@ cdm::VideoDecoderConfig::VideoCodecProfile PpVCProfileToCdmVCProfile(
return cdm::VideoDecoderConfig::kH264ProfileHigh422;
case PP_VIDEOCODECPROFILE_H264_HIGH_444_PREDICTIVE:
return cdm::VideoDecoderConfig::kH264ProfileHigh444Predictive;
+ // TODO(servolk): See crbug.com/592074. We'll need to update this code to
ddorwin 2016/03/28 18:45:46 We might need to be smarter about how we implement
servolk 2016/03/28 19:03:02 Acknowledged.
+ // handle different VP9 profiles properly after adding VP9 profiles in
+ // media/cdm/api/content_decryption_module.h in a separate CL.
+ // For now return kProfileNotNeeded to avoid breaking unit tests.
ddorwin 2016/03/28 18:45:45 Which unit tests? How does this avoid breaking the
servolk 2016/03/28 19:03:01 In earlier patchsets #7,#8 of this CL trybots indi
+ case PP_VIDEOCODECPROFILE_VP9_PROFILE0:
+ case PP_VIDEOCODECPROFILE_VP9_PROFILE1:
+ case PP_VIDEOCODECPROFILE_VP9_PROFILE2:
+ case PP_VIDEOCODECPROFILE_VP9_PROFILE3:
+ return cdm::VideoDecoderConfig::kProfileNotNeeded;
default:
return cdm::VideoDecoderConfig::kUnknownVideoCodecProfile;
}

Powered by Google App Engine
This is Rietveld 408576698