Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1769583002: Swarming tasks: print start and end time (Closed)

Created:
4 years, 9 months ago by borenet
Modified:
4 years, 9 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Swarming tasks: print start and end time This will help determine how long each component of the task takes. NOTRY=true BUG=skia:4763 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769583002 Committed: https://skia.googlesource.com/skia/+/d4f89e4e391d00e1011e3bbafc90743335e40030

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix missing import #

Patch Set 3 : Add utils module with print_timings helper #

Total comments: 2

Patch Set 4 : Fix unused import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M infra/bots/compile_skia.py View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M infra/bots/perf_skia.py View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M infra/bots/test_skia.py View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
A infra/bots/utils.py View 1 2 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769583002/1
4 years, 9 months ago (2016-03-04 18:18:42 UTC) #3
borenet
4 years, 9 months ago (2016-03-04 18:19:25 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/7295)
4 years, 9 months ago (2016-03-04 18:20:13 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769583002/20001
4 years, 9 months ago (2016-03-04 18:20:42 UTC) #9
rmistry
https://codereview.chromium.org/1769583002/diff/1/infra/bots/compile_skia.py File infra/bots/compile_skia.py (right): https://codereview.chromium.org/1769583002/diff/1/infra/bots/compile_skia.py#newcode24 infra/bots/compile_skia.py:24: print 'Task finished at %s UTC' % time.asctime(time.gmtime()) Why ...
4 years, 9 months ago (2016-03-04 18:20:59 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-04 18:21:54 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769583002/40001
4 years, 9 months ago (2016-03-04 18:48:09 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-04 18:49:21 UTC) #16
borenet
Sigh. I miss Go's time package. https://codereview.chromium.org/1769583002/diff/1/infra/bots/compile_skia.py File infra/bots/compile_skia.py (right): https://codereview.chromium.org/1769583002/diff/1/infra/bots/compile_skia.py#newcode24 infra/bots/compile_skia.py:24: print 'Task finished ...
4 years, 9 months ago (2016-03-04 18:50:01 UTC) #17
rmistry
lgtm https://codereview.chromium.org/1769583002/diff/40001/infra/bots/perf_skia.py File infra/bots/perf_skia.py (right): https://codereview.chromium.org/1769583002/diff/40001/infra/bots/perf_skia.py#newcode13 infra/bots/perf_skia.py:13: import time unused
4 years, 9 months ago (2016-03-04 18:53:26 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769583002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769583002/60001
4 years, 9 months ago (2016-03-04 18:57:13 UTC) #20
borenet
https://codereview.chromium.org/1769583002/diff/40001/infra/bots/perf_skia.py File infra/bots/perf_skia.py (right): https://codereview.chromium.org/1769583002/diff/40001/infra/bots/perf_skia.py#newcode13 infra/bots/perf_skia.py:13: import time On 2016/03/04 18:53:25, rmistry wrote: > unused ...
4 years, 9 months ago (2016-03-04 18:57:24 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769583002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769583002/60001
4 years, 9 months ago (2016-03-04 18:57:54 UTC) #25
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 18:58:24 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d4f89e4e391d00e1011e3bbafc90743335e40030

Powered by Google App Engine
This is Rietveld 408576698