Move testRunner.startSpeechInput/setValueForUser to internals

Move testRunner.startSpeechInput/setValueForUser to internals

Now TestRunner is being moved from CppBoundClass to gin::Wrappable,
where it is not appropriate to use WebElements directly. This CL moves
some functions which treats WebElement* from testRunner to internals.
(To be exact, this CL only copies some functions, but I'll remove those ones
in testRunner later.)

BUG=331301
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168495

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168588

[hajimehoshi, 2014-03-04 06:16:33]

PTAL

[haraken, 2014-03-04 06:19:41]

LGTM with comments.

https://codereview.chromium.org/176953009/diff/1/LayoutTests/fast/speech/inpu...
File LayoutTests/fast/speech/input-text-speechstart.html (right):

https://codereview.chromium.org/176953009/diff/1/LayoutTests/fast/speech/inpu...
LayoutTests/fast/speech/input-text-speechstart.html:17: console.log(internals);

Remove this.

https://codereview.chromium.org/176953009/diff/1/Source/core/testing/Internals.h
File Source/core/testing/Internals.h (right):

https://codereview.chromium.org/176953009/diff/1/Source/core/testing/Internal...
Source/core/testing/Internals.h:318: void setValueForUser(Element*, const
String&);

I'd rename this method to make it clear that it's about speech input.
"setSpeechInputValue"?

[hajimehoshi, 2014-03-04 06:27:19]

Thank you!

https://codereview.chromium.org/176953009/diff/1/LayoutTests/fast/speech/inpu...
File LayoutTests/fast/speech/input-text-speechstart.html (right):

https://codereview.chromium.org/176953009/diff/1/LayoutTests/fast/speech/inpu...
LayoutTests/fast/speech/input-text-speechstart.html:17: console.log(internals);
On 2014/03/04 06:19:41, haraken wrote:
> 
> Remove this.

Oops, Done.

https://codereview.chromium.org/176953009/diff/1/Source/core/testing/Internals.h
File Source/core/testing/Internals.h (right):

https://codereview.chromium.org/176953009/diff/1/Source/core/testing/Internal...
Source/core/testing/Internals.h:318: void setValueForUser(Element*, const
String&);
On 2014/03/04 06:19:41, haraken wrote:
> 
> I'd rename this method to make it clear that it's about speech input.
> "setSpeechInputValue"?

Sorry but this was mistake. This method has nothing to do with speech. Fixed the
function definition.

[hajimehoshi, 2014-03-04 06:27:49]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2014-03-04 06:27:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/176953009/20001

[kouhei (in TOK), 2014-03-04 06:29:58]

On 2014/03/04 06:27:58, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>
https://chromium-status.appspot.com/cq/hajimehoshi%40chromium.org/176953009/2...

lgtm

[hajimehoshi, 2014-03-05 02:15:00]

The CQ bit was unchecked by hajimehoshi@chromium.org

[hajimehoshi, 2014-03-05 02:15:00]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2014-03-05 16:21:46]

Change committed as 168495

[Peter Beverloo, 2014-03-05 17:40:30]

A revert of this CL has been created in
https://codereview.chromium.org/187903004/ by peter@chromium.org.

The reason for reverting is: Broke the Android compile:
 
http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20%28d...

Android does not enable speech input, and the methods called are guarded behind
the ENABLE_INPUT_SPEECH compile-time flag. The testing code in Internals.cpp
should also be guarded with the same flag..

[hajimehoshi, 2014-03-06 02:26:13]

On 2014/03/05 17:40:30, Peter Beverloo wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/187903004/ by mailto:peter@chromium.org.
> 
> The reason for reverting is: Broke the Android compile:
>  
>
http://build.chromium.org/p/chromium.webkit/builders/Android%2520Builder%2520...
> 
> Android does not enable speech input, and the methods called are guarded
behind
> the ENABLE_INPUT_SPEECH compile-time flag. The testing code in Internals.cpp
> should also be guarded with the same flag..

Oh, thanks. Done.

[hajimehoshi, 2014-03-06 02:26:52]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2014-03-06 02:28:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/176953009/40001

[commit-bot: I haz the power, 2014-03-06 02:28:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 02:28:33]

Failed to apply patch for Source/core/testing/Internals.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/testing/Internals.cpp
  Hunk #1 FAILED at 89.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/testing/Internals.cpp.rej

Patch:       Source/core/testing/Internals.cpp
Index: Source/core/testing/Internals.cpp
diff --git a/Source/core/testing/Internals.cpp
b/Source/core/testing/Internals.cpp
index
be307adca331446e8c413a612bb497a41ca088ee..35eefdd571d7befe37ad3f07fde5dda4868003e5
100644
--- a/Source/core/testing/Internals.cpp
+++ b/Source/core/testing/Internals.cpp
@@ -89,6 +89,8 @@
 #include "core/html/HTMLTextAreaElement.h"
 #include "core/html/forms/FormController.h"
 #include "core/html/shadow/HTMLContentElement.h"
+#include "core/html/shadow/ShadowElementNames.h"
+#include "core/html/shadow/TextControlInnerElements.h"
 #include "core/inspector/InspectorClient.h"
 #include "core/inspector/InspectorConsoleAgent.h"
 #include "core/inspector/InspectorController.h"
@@ -2387,4 +2389,22 @@ void Internals::trace(Visitor* visitor)
     visitor->trace(m_profilers);
 }
 
+void Internals::startSpeechInput(Element* element)
+{
+#if ENABLE(INPUT_SPEECH)
+    HTMLInputElement* input = toHTMLInputElement(element);
+    if (!input->isSpeechEnabled())
+        return;
+
+    InputFieldSpeechButtonElement* speechButton =
toInputFieldSpeechButtonElement(input->userAgentShadowRoot()->getElementById(ShadowElementNames::speechButton()));
+    if (speechButton)
+        speechButton->startSpeechInput();
+#endif
+}
+
+void Internals::setValueForUser(Element* element, const String& value)
+{
+    toHTMLInputElement(element)->setValueForUser(value);
+}
+
 }

[hajimehoshi, 2014-03-06 03:49:04]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2014-03-06 03:49:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/176953009/60001

[commit-bot: I haz the power, 2014-03-06 03:49:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 03:49:31]

Failed to apply patch for Source/core/testing/Internals.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/testing/Internals.cpp
  Hunk #1 FAILED at 89.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/testing/Internals.cpp.rej

Patch:       Source/core/testing/Internals.cpp
Index: Source/core/testing/Internals.cpp
diff --git a/Source/core/testing/Internals.cpp
b/Source/core/testing/Internals.cpp
index
be307adca331446e8c413a612bb497a41ca088ee..35eefdd571d7befe37ad3f07fde5dda4868003e5
100644
--- a/Source/core/testing/Internals.cpp
+++ b/Source/core/testing/Internals.cpp
@@ -89,6 +89,8 @@
 #include "core/html/HTMLTextAreaElement.h"
 #include "core/html/forms/FormController.h"
 #include "core/html/shadow/HTMLContentElement.h"
+#include "core/html/shadow/ShadowElementNames.h"
+#include "core/html/shadow/TextControlInnerElements.h"
 #include "core/inspector/InspectorClient.h"
 #include "core/inspector/InspectorConsoleAgent.h"
 #include "core/inspector/InspectorController.h"
@@ -2387,4 +2389,22 @@ void Internals::trace(Visitor* visitor)
     visitor->trace(m_profilers);
 }
 
+void Internals::startSpeechInput(Element* element)
+{
+#if ENABLE(INPUT_SPEECH)
+    HTMLInputElement* input = toHTMLInputElement(element);
+    if (!input->isSpeechEnabled())
+        return;
+
+    InputFieldSpeechButtonElement* speechButton =
toInputFieldSpeechButtonElement(input->userAgentShadowRoot()->getElementById(ShadowElementNames::speechButton()));
+    if (speechButton)
+        speechButton->startSpeechInput();
+#endif
+}
+
+void Internals::setValueForUser(Element* element, const String& value)
+{
+    toHTMLInputElement(element)->setValueForUser(value);
+}
+
 }

[hajimehoshi, 2014-03-06 04:04:16]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2014-03-06 04:04:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/176953009/80001

[commit-bot: I haz the power, 2014-03-06 08:01:11]

Change committed as 168588