Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 176953008: Include the outline into the visual overflow (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed dumb bug caught by Mac. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index c111f2c4bd18fec240b84fd55b0b9862c15f6f04..6506231271fc7ef70b5da4f87fc8edc347f3b4be 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -865,10 +865,6 @@ void FrameView::layout(bool allowSubtree)
RELEASE_ASSERT(!isPainting());
- // Store the current maximal outline size to use when computing the old/new
- // outline rects for repainting.
- renderView()->setOldMaximalOutlineSize(renderView()->maximalOutlineSize());
-
InspectorInstrumentationCookie cookie = InspectorInstrumentation::willLayout(m_frame.get());
if (!allowSubtree && isSubtreeLayout()) {
@@ -1056,10 +1052,8 @@ void FrameView::repaintTree(RenderObject* root)
const LayoutRect& newRepaintRect = renderer->newRepaintRect();
LayoutRect oldOutlineRect = oldRepaintRect;
- oldOutlineRect.inflate(renderView()->oldMaximalOutlineSize());
LayoutRect newOutlineRect = newRepaintRect;
- newOutlineRect.inflate(renderView()->maximalOutlineSize());
// FIXME: Currently renderers with layers will get repainted when we call updateLayerPositionsAfterLayout.
// That call should be broken apart to position the layers be done before
@@ -1100,7 +1094,6 @@ void FrameView::repaintTree(RenderObject* root)
renderer->clearRepaintRects();
}
- renderView()->setOldMaximalOutlineSize(0);
// Repaint the frameviews scrollbars if needed
if (hasVerticalBarDamage())
« no previous file with comments | « LayoutTests/platform/win/fast/repaint/outline-shrinking-expected.txt ('k') | Source/core/rendering/InlineFlowBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698