Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: Source/core/rendering/RenderTableRow.cpp

Issue 176953008: Include the outline into the visual overflow (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 if (!cell->needsLayout() && paginated && view()->layoutState()->page LogicalHeight() && view()->layoutState()->pageLogicalOffset(*cell, cell->logical Top()) != cell->pageLogicalOffset()) 174 if (!cell->needsLayout() && paginated && view()->layoutState()->page LogicalHeight() && view()->layoutState()->pageLogicalOffset(*cell, cell->logical Top()) != cell->pageLogicalOffset())
175 layouter.setChildNeedsLayout(cell); 175 layouter.setChildNeedsLayout(cell);
176 176
177 if (child->needsLayout()) { 177 if (child->needsLayout()) {
178 cell->computeAndSetBlockDirectionMargins(table()); 178 cell->computeAndSetBlockDirectionMargins(table());
179 cell->layout(); 179 cell->layout();
180 } 180 }
181 } 181 }
182 } 182 }
183 183
184 addVisualEffectOverflow();
185
184 // We only ever need to repaint if our cells didn't, which means that they d idn't need 186 // We only ever need to repaint if our cells didn't, which means that they d idn't need
185 // layout, so we know that our bounds didn't change. This code is just makin g up for 187 // layout, so we know that our bounds didn't change. This code is just makin g up for
186 // the fact that we did not repaint in setStyle() because we had a layout hi nt. 188 // the fact that we did not repaint in setStyle() because we had a layout hi nt.
187 // We cannot call repaint() because our clippedOverflowRectForRepaint() is t aken from the 189 // We cannot call repaint() because our clippedOverflowRectForRepaint() is t aken from the
188 // parent table, and being mid-layout, that is invalid. Instead, we repaint our cells. 190 // parent table, and being mid-layout, that is invalid. Instead, we repaint our cells.
189 if (selfNeedsLayout() && checkForRepaint()) { 191 if (selfNeedsLayout() && checkForRepaint()) {
190 for (RenderObject* child = firstChild(); child; child = child->nextSibli ng()) { 192 for (RenderObject* child = firstChild(); child; child = child->nextSibli ng()) {
191 if (child->isTableCell()) { 193 if (child->isTableCell()) {
192 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled()) { 194 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled()) {
193 // FIXME: Is this needed with repaint After Layout? 195 // FIXME: Is this needed with repaint After Layout?
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 287
286 RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb ject* parent) 288 RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb ject* parent)
287 { 289 {
288 RenderTableRow* newRow = RenderTableRow::createAnonymous(&parent->document() ); 290 RenderTableRow* newRow = RenderTableRow::createAnonymous(&parent->document() );
289 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_ROW); 291 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_ROW);
290 newRow->setStyle(newStyle.release()); 292 newRow->setStyle(newStyle.release());
291 return newRow; 293 return newRow;
292 } 294 }
293 295
294 } // namespace WebCore 296 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698