Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1769523002: [compiler] Better description of compiler API. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-api-4
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Better description of compiler API. This adds more comments to the V8 compiler API explaining the entry methods within that API. It also establishes a separate method for OSR compilation since {Compiler::GetOptimizedCode} is only used for OSR by now. R=danno@chromium.org Committed: https://crrev.com/970f1ae610349eea2e011f76f8ae1ebe9b8f35b0 Cr-Commit-Position: refs/heads/master@{#34503}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -90 lines) Patch
M src/compiler.h View 1 3 chunks +35 lines, -16 lines 0 comments Download
M src/compiler.cc View 1 4 chunks +83 lines, -73 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-04 15:35:26 UTC) #1
danno
lgtm
4 years, 9 months ago (2016-03-04 15:41:30 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 1764023003 Patch 1). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-04 15:46:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769523002/20001
4 years, 9 months ago (2016-03-04 15:47:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 16:11:02 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 16:11:18 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/970f1ae610349eea2e011f76f8ae1ebe9b8f35b0
Cr-Commit-Position: refs/heads/master@{#34503}

Powered by Google App Engine
This is Rietveld 408576698