Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: third_party/pkg/angular/lib/filter/filter.dart

Issue 176943008: Update the Angular/DI tests to latest from github. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/pkg/angular/lib/filter/filter.dart
diff --git a/third_party/pkg/angular/lib/filter/filter.dart b/third_party/pkg/angular/lib/filter/filter.dart
index 71ef5db89b6389f803ef98d2d2a167cd46e31621..1203466dcfa79b20c6a1784bf1b6164e137a3cd4 100644
--- a/third_party/pkg/angular/lib/filter/filter.dart
+++ b/third_party/pkg/angular/lib/filter/filter.dart
@@ -125,7 +125,7 @@ class FilterFilter {
FilterFilter(this._parser);
- Equals _configureComparator(var comparatorExpression) {
+ void _configureComparator(var comparatorExpression) {
if (comparatorExpression == null || comparatorExpression == false) {
_stringComparator = _isSubstringCaseInsensitive;
_comparator = _defaultComparator;
@@ -199,7 +199,8 @@ class FilterFilter {
if (expression == null) {
return items.toList(growable: false); // Missing expression → passthrough.
} else if (expression is! Map && expression is! Function &&
- expression is! String && expression is! bool && expression is! num) {
+ expression is! String && expression is! bool &&
+ expression is! num) {
return const []; // Bad expression → no items for you!
}
_configureComparator(comparator);

Powered by Google App Engine
This is Rietveld 408576698