Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: third_party/pkg/angular/lib/directive/ng_a.dart

Issue 176943008: Update the Angular/DI tests to latest from github. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/pkg/angular/lib/directive/ng_a.dart
diff --git a/third_party/pkg/angular/lib/directive/ng_a.dart b/third_party/pkg/angular/lib/directive/ng_a.dart
index 59d99c09565a30b08c3ec97f4e319049ebbf0da2..91b7b5590b0e3ef3209e6fa475cfcbc668e7ba84 100644
--- a/third_party/pkg/angular/lib/directive/ng_a.dart
+++ b/third_party/pkg/angular/lib/directive/ng_a.dart
@@ -7,7 +7,7 @@ part of angular.directive;
*
* @description
* Modifies the default behavior of the html A tag so that the default action is prevented when
- * the href attribute is empty.
+ * the a href is empty or it contains `ng-click` directive.
*
* This change permits the easy creation of action links with the `ngClick` directive
* without changing the location or causing page reloads, e.g.:
@@ -15,10 +15,11 @@ part of angular.directive;
*/
@NgDirective(selector: 'a[href]')
class NgADirective {
- dom.Element element;
+ final dom.Element element;
- NgADirective(dom.Element element) {
- if (element.attributes["href"] == "") {
+ NgADirective(this.element) {
+ if (element.attributes["href"] == "" ||
+ element.attributes.containsKey('ng-click')) {
element.onClick.listen((event) {
if (element.attributes["href"] == "") {
event.preventDefault();

Powered by Google App Engine
This is Rietveld 408576698