Check for Renderer in SendAutofillTypePredictionsToRenderer

Cleanup SendAutofillTypePredictionsToRenderer

Minor refactoring/code cleanup adding the check for Renderer to do an early return if the Renderer is not available.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255010

[spartha, 2014-02-26 05:52:05]

Minor change PTAL.

[spartha, 2014-03-03 09:41:12]

On 2014/02/26 05:52:05, spartha wrote:
> Minor change PTAL.

Will close the review if this is not worth the change.

[Ilya Sherman, 2014-03-03 23:07:34]

Thanks for the cleanup patch.  LG with the following fixes:

https://codereview.chromium.org/176943007/diff/1/components/autofill/content/...
File components/autofill/content/browser/autofill_driver_impl.cc (right):

https://codereview.chromium.org/176943007/diff/1/components/autofill/content/...
components/autofill/content/browser/autofill_driver_impl.cc:121: return;
Please reformat this like so:

if (!CommandLine::ForCurrentProcess()->HasSwitch(
        switches::kShowAutofillTypePredictions))
  return;

if (!RendererIsAvailable())
  return;

https://codereview.chromium.org/176943007/diff/1/components/autofill/content/...
components/autofill/content/browser/autofill_driver_impl.cc:125: return;
This if-stmt is no longer needed if you want to switch to using the named
RendererIsAvailable() method instead.

[Ilya Sherman, 2014-03-03 23:08:30]

Also, please update the CL description to indicate that this is a cleanup patch
to make style more consistent throughout the file, rather than a functionality
change.  The check already existed in the function; it was just written in a
different way.

[Garrett Casto, 2014-03-03 23:32:17]

Apologies that this got dropped, I wasn't checking the dashboard to my Google
account. Ilya is a better person to review this anyway.

[spartha, 2014-03-04 16:24:39]

Thanks for review. Updated the patch as per the review comments. PTAL

https://codereview.chromium.org/176943007/diff/1/components/autofill/content/...
File components/autofill/content/browser/autofill_driver_impl.cc (right):

https://codereview.chromium.org/176943007/diff/1/components/autofill/content/...
components/autofill/content/browser/autofill_driver_impl.cc:121: return;
On 2014/03/03 23:07:34, Ilya Sherman wrote:
> Please reformat this like so:
> 
> if (!CommandLine::ForCurrentProcess()->HasSwitch(
>         switches::kShowAutofillTypePredictions))
>   return;
> 
> if (!RendererIsAvailable())
>   return;

Done.

https://codereview.chromium.org/176943007/diff/1/components/autofill/content/...
components/autofill/content/browser/autofill_driver_impl.cc:125: return;
On 2014/03/03 23:07:34, Ilya Sherman wrote:
> This if-stmt is no longer needed if you want to switch to using the named
> RendererIsAvailable() method instead.

Done.

[Ilya Sherman, 2014-03-04 22:37:23]

Thanks.  Please also update the CL description, as I requested in my previous
review.

[spartha, 2014-03-05 03:06:09]

On 2014/03/04 22:37:23, Ilya Sherman wrote:
> Thanks.  Please also update the CL description, as I requested in my previous
> review.

Sorry missed that. Updated, PTAL

[Ilya Sherman, 2014-03-05 05:08:08]

LGTM, thanks

[spartha, 2014-03-05 07:23:19]

The CQ bit was checked by sudarshan.p@samsung.com

[commit-bot: I haz the power, 2014-03-05 07:24:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/176943007/20001

[commit-bot: I haz the power, 2014-03-05 08:49:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 08:49:48]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[spartha, 2014-03-05 09:17:19]

The CQ bit was checked by sudarshan.p@samsung.com

[commit-bot: I haz the power, 2014-03-05 09:18:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/176943007/20001

[commit-bot: I haz the power, 2014-03-05 11:27:07]

Change committed as 255010