content/port/browser/render_widget_host_view_port.h - Issue 176943004: [Android] Implement asynchronous zero-copy bitmap capture API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/port/browser/render_widget_host_view_port.h

Issue 176943004: [Android] Implement asynchronous zero-copy bitmap capture API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/content_view_core_impl.cc ('K') | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/port/browser/render_widget_host_view_port.h

diff --git a/content/port/browser/render_widget_host_view_port.h b/content/port/browser/render_widget_host_view_port.h

index ae00425b9fcf91ce8fd7127669dd29959d213539..30702cd8075c547f5c9befb05615fbab8ad93fb6 100644

--- a/content/port/browser/render_widget_host_view_port.h

+++ b/content/port/browser/render_widget_host_view_port.h

@@ -182,7 +182,8 @@ class CONTENT_EXPORT RenderWidgetHostViewPort : public RenderWidgetHostView,

const gfx::Rect& src_subrect,

const gfx::Size& dst_size,

const base::Callback<void(bool, const SkBitmap&)>& callback,

- const SkBitmap::Config config) = 0;

+ const SkBitmap::Config config,

+ scoped_ptr<SkBitmap> bitmap = scoped_ptr<SkBitmap>()) = 0;

piman 2014/03/05 21:07:23 nit: no default argument. I don't think it's ok t

// Copies a given subset of the compositing surface's content into a YV12

// VideoFrame, and invokes a callback with a success/fail parameter. |target|