Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 17694002: Restore message when rethrowing in TryCatch. (Closed)

Created:
7 years, 6 months ago by Yang
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Restore message when rethrowing in TryCatch. Based on a patch contributed by Andrew Paprocki <andrew@ishiboo.com>;. R=jkummerow@chromium.org BUG= TEST=cctest/test-api/TryCatchNestedSyntax Committed: https://code.google.com/p/v8/source/detail?r=15408

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -21 lines) Patch
M include/v8.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/api.cc View 1 4 chunks +19 lines, -6 lines 0 comments Download
M src/isolate.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/isolate.cc View 7 chunks +44 lines, -12 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
7 years, 6 months ago (2013-06-25 15:49:53 UTC) #1
apaprocki
Everything looks good aside from just fixing that comment. I built this change into Node ...
7 years, 6 months ago (2013-06-26 03:22:52 UTC) #2
Jakob Kummerow
rubber-stamp LGTM
7 years, 6 months ago (2013-06-26 08:58:04 UTC) #3
Yang
On 2013/06/26 08:58:04, Jakob wrote: > rubber-stamp LGTM Since this CL has the chance to ...
7 years, 6 months ago (2013-06-26 08:59:29 UTC) #4
Yang
7 years, 5 months ago (2013-07-01 10:54:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r15408 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698