AudioBus: Add a ToInterleavedFloat() method to AudioBus

media/base/audio_bus.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/audio_bus.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <limits>
@@ skipping 279 matching lines @@
 void AudioBus::FromInterleaved(const void* source, int frames,
                                int bytes_per_sample) {
   FromInterleavedPartial(source, 0, frames, bytes_per_sample);
 }
 
 void AudioBus::ToInterleaved(int frames, int bytes_per_sample,
                              void* dest) const {
   ToInterleavedPartial(0, frames, bytes_per_sample, dest);
 }
 
+// Interleaves |audio_bus| channels() of floats into a single output linear
+// |buffer|.
+void AudioBus::ToInterleavedFloat(int source_offset,
+                                  int destination_offset,
+                                  int num_samples,

[mcasas, 2016/04/11 23:47:08]

This parameter is called |int num_channels| in the
method declaration. Only one is correct, and beyond
that, if you allow the caller to specify |num_samples|,
then this method should be suffixed Partial like
in l.317.

Also try to follow the other ToInterleaved*() variable
naming convention, e.g. |dest|, |start_frame| etc.

+                                  float* buffer) const {
+  CheckOverflow(source_offset, destination_offset, num_samples);
+  for (int ch = 0; ch < channels(); ++ch) {
+    const float* src = channel(ch) + source_offset;
+    const float* const src_end = src + num_samples;
+    float* dest = buffer + destination_offset + ch;
+    for (; src < src_end; ++src, dest += channels())
+      *dest = *src;
+  }
+}
+
 // TODO(dalecurtis): See if intrinsic optimizations help any here.
 void AudioBus::ToInterleavedPartial(int start_frame, int frames,
                                     int bytes_per_sample, void* dest) const {
   CheckOverflow(start_frame, frames, frames_);
   switch (bytes_per_sample) {
     case 1:
       ToInterleavedInternal<uint8_t, int16_t, kUint8Bias>(
           this, start_frame, frames, dest, std::numeric_limits<int8_t>::min(),
           std::numeric_limits<int8_t>::max());
       break;
@@ skipping 56 matching lines @@
   return scoped_refptr<AudioBusRefCounted>(
       new AudioBusRefCounted(channels, frames));
 }
 
 AudioBusRefCounted::AudioBusRefCounted(int channels, int frames)
     : AudioBus(channels, frames) {}
 
 AudioBusRefCounted::~AudioBusRefCounted() {}
 
 }  // namespace media