Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1769373002: Disallow @apply rules in non-custom property declarations (Closed)

Created:
4 years, 9 months ago by Timothy Loh
Modified:
4 years, 9 months ago
Reviewers:
dstockwell
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@foo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow @apply rules in non-custom property declarations This patch disallows the use of @apply inside non-custom property declarations. @apply should only be allowed where we can have a list of property declarations. BUG=586974 Committed: https://crrev.com/cd0ab5da4c012ac338e5dfe3aecae36e51aeabf2 Cr-Commit-Position: refs/heads/master@{#380039}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : initialize variable :< #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-in-regular-property.html View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-in-regular-property-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp View 1 2 7 chunks +16 lines, -13 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Timothy Loh
4 years, 9 months ago (2016-03-08 00:52:49 UTC) #3
dstockwell
lgtm
4 years, 9 months ago (2016-03-08 01:33:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769373002/1
4 years, 9 months ago (2016-03-08 01:40:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/141488) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-08 01:44:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769373002/20001
4 years, 9 months ago (2016-03-08 04:59:28 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/185540)
4 years, 9 months ago (2016-03-08 07:15:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769373002/40001
4 years, 9 months ago (2016-03-09 00:58:40 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-09 02:37:52 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 02:40:57 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cd0ab5da4c012ac338e5dfe3aecae36e51aeabf2
Cr-Commit-Position: refs/heads/master@{#380039}

Powered by Google App Engine
This is Rietveld 408576698