Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Side by Side Diff: Source/core/html/HTMLFormControlsCollection.cpp

Issue 176933013: Pass rootNode by reference when constructing node lists / collections (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLFormControlsCollection.h ('k') | Source/core/html/HTMLNameCollection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2010, 2011, 2012 Apple Inc. All r ights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2010, 2011, 2012 Apple Inc. All r ights reserved.
5 * Copyright (C) 2014 Samsung Electronics. All rights reserved. 5 * Copyright (C) 2014 Samsung Electronics. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 20 matching lines...) Expand all
31 #include "core/html/HTMLImageElement.h" 31 #include "core/html/HTMLImageElement.h"
32 #include "wtf/HashSet.h" 32 #include "wtf/HashSet.h"
33 33
34 namespace WebCore { 34 namespace WebCore {
35 35
36 using namespace HTMLNames; 36 using namespace HTMLNames;
37 37
38 // Since the collections are to be "live", we have to do the 38 // Since the collections are to be "live", we have to do the
39 // calculation every time if anything has changed. 39 // calculation every time if anything has changed.
40 40
41 HTMLFormControlsCollection::HTMLFormControlsCollection(ContainerNode* ownerNode) 41 HTMLFormControlsCollection::HTMLFormControlsCollection(ContainerNode& ownerNode)
42 : HTMLCollection(ownerNode, FormControls, OverridesItemAfter) 42 : HTMLCollection(ownerNode, FormControls, OverridesItemAfter)
43 , m_cachedElement(0) 43 , m_cachedElement(0)
44 , m_cachedElementOffsetInArray(0) 44 , m_cachedElementOffsetInArray(0)
45 { 45 {
46 ASSERT(ownerNode->hasTagName(formTag) || ownerNode->hasTagName(fieldsetTag)) ; 46 ASSERT(ownerNode.hasTagName(formTag) || ownerNode.hasTagName(fieldsetTag));
47 ScriptWrappable::init(this); 47 ScriptWrappable::init(this);
48 } 48 }
49 49
50 PassRefPtr<HTMLFormControlsCollection> HTMLFormControlsCollection::create(Contai nerNode* ownerNode, CollectionType) 50 PassRefPtr<HTMLFormControlsCollection> HTMLFormControlsCollection::create(Contai nerNode& ownerNode, CollectionType)
51 { 51 {
52 return adoptRef(new HTMLFormControlsCollection(ownerNode)); 52 return adoptRef(new HTMLFormControlsCollection(ownerNode));
53 } 53 }
54 54
55 HTMLFormControlsCollection::~HTMLFormControlsCollection() 55 HTMLFormControlsCollection::~HTMLFormControlsCollection()
56 { 56 {
57 } 57 }
58 58
59 const Vector<FormAssociatedElement*>& HTMLFormControlsCollection::formControlEle ments() const 59 const Vector<FormAssociatedElement*>& HTMLFormControlsCollection::formControlEle ments() const
60 { 60 {
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 const AtomicString& nameAttribute = element->getNameAttribute(); 229 const AtomicString& nameAttribute = element->getNameAttribute();
230 if (!nameAttribute.isEmpty()) { 230 if (!nameAttribute.isEmpty()) {
231 HashSet<AtomicString>::AddResult addResult = existingNames.add(nameA ttribute); 231 HashSet<AtomicString>::AddResult addResult = existingNames.add(nameA ttribute);
232 if (addResult.isNewEntry) 232 if (addResult.isNewEntry)
233 names.append(nameAttribute); 233 names.append(nameAttribute);
234 } 234 }
235 } 235 }
236 } 236 }
237 237
238 } 238 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLFormControlsCollection.h ('k') | Source/core/html/HTMLNameCollection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698