runtime/bin/process_linux.cc - Issue 176933006: Use signal-block around fork() to avoid we block it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/process_linux.cc

Issue 176933006: Use signal-block around fork() to avoid we block it. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/process_linux.cc

diff --git a/runtime/bin/process_linux.cc b/runtime/bin/process_linux.cc

index 037dd16c39b7c90b9a570ba26f7375a6a57b6d5f..e2810fc6dc17a4c37f52e25ad50abdf9db371ace 100644

--- a/runtime/bin/process_linux.cc

+++ b/runtime/bin/process_linux.cc

@@ -151,7 +151,7 @@ class ExitCodeHandler {

running_ = false;

// Fork to wake up waitpid.

- if (TEMP_FAILURE_RETRY(fork()) == 0) {

+ if (TEMP_FAILURE_RETRY_BLOCK_SIGNALS(fork()) == 0) {

exit(0);

}

@@ -349,7 +349,7 @@ int Process::Start(const char* path,

program_environment[environment_length] = NULL;

}

- pid = TEMP_FAILURE_RETRY(fork());

+ pid = TEMP_FAILURE_RETRY_BLOCK_SIGNALS(fork());

if (pid < 0) {

SetChildOsErrorMessage(os_error_message);

delete[] program_arguments;

« no previous file with comments | « runtime/bin/process_android.cc ('k') | runtime/bin/process_macos.cc » ('j') | no next file with comments »