Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1769303002: Support different file extensions for LLVMgold.so (Closed)

Created:
4 years, 9 months ago by Petr Hosek
Modified:
4 years, 9 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/a/native_client/pnacl-clang.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support different file extensions for LLVM gold plugin The LLVM gold plugin may have different extensions on different systems. BUG=none R=dschuff@chromium.org Committed: a2e4b291fd563d432dc9e8192aad374d80905319

Patch Set 1 #

Total comments: 2

Patch Set 2 : Explicitly enumerate possible extensions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/Driver/pnacl-direct.c View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Petr Hosek
Unfortunately, it seems like "-plugin-opt=emit-llvm" needs to be on the same line otherwise {{.*}} consumes ...
4 years, 9 months ago (2016-03-07 22:47:47 UTC) #1
Derek Schuff
https://codereview.chromium.org/1769303002/diff/1/test/Driver/pnacl-direct.c File test/Driver/pnacl-direct.c (left): https://codereview.chromium.org/1769303002/diff/1/test/Driver/pnacl-direct.c#oldcode33 test/Driver/pnacl-direct.c:33: // CHECK-LE32: "-plugin" "{{.*}}{{/|\\\\}}..{{/|\\\\}}lib{{/|\\\\}}LLVMgold.so" could this just be {{.so|.dll}} ...
4 years, 9 months ago (2016-03-07 22:54:41 UTC) #2
Petr Hosek
https://codereview.chromium.org/1769303002/diff/1/test/Driver/pnacl-direct.c File test/Driver/pnacl-direct.c (left): https://codereview.chromium.org/1769303002/diff/1/test/Driver/pnacl-direct.c#oldcode33 test/Driver/pnacl-direct.c:33: // CHECK-LE32: "-plugin" "{{.*}}{{/|\\\\}}..{{/|\\\\}}lib{{/|\\\\}}LLVMgold.so" On 2016/03/07 22:54:41, Derek Schuff ...
4 years, 9 months ago (2016-03-07 22:58:49 UTC) #3
Derek Schuff
lgtm
4 years, 9 months ago (2016-03-07 23:06:48 UTC) #4
Petr Hosek
4 years, 9 months ago (2016-03-07 23:26:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a2e4b291fd563d432dc9e8192aad374d80905319 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698