Index: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp |
diff --git a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp |
index e752b66cc80ee22f426b79d7b7838902678feb4e..25536bed4f3386f1fd6639f5c8fc977dd58be80d 100644 |
--- a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp |
+++ b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp |
@@ -31,15 +31,13 @@ |
#include "platform/v8_inspector/JavaScriptCallFrame.h" |
#include "platform/v8_inspector/V8StringUtil.h" |
-#include "platform/v8_inspector/public/V8DebuggerClient.h" |
#include <v8-debug.h> |
namespace blink { |
-JavaScriptCallFrame::JavaScriptCallFrame(V8DebuggerClient* client, v8::Local<v8::Context> debuggerContext, v8::Local<v8::Object> callFrame) |
- : m_client(client) |
- , m_isolate(debuggerContext->GetIsolate()) |
+JavaScriptCallFrame::JavaScriptCallFrame(v8::Local<v8::Context> debuggerContext, v8::Local<v8::Object> callFrame) |
+ : m_isolate(debuggerContext->GetIsolate()) |
, m_debuggerContext(m_isolate, debuggerContext) |
, m_callFrame(m_isolate, callFrame) |
{ |
@@ -57,17 +55,18 @@ PassOwnPtr<JavaScriptCallFrame> JavaScriptCallFrame::caller() |
v8::Local<v8::Value> callerFrame = v8::Local<v8::Object>::New(m_isolate, m_callFrame)->Get(toV8StringInternalized(m_isolate, "caller")); |
if (callerFrame.IsEmpty() || !callerFrame->IsObject()) |
return 0; |
- return JavaScriptCallFrame::create(m_client, debuggerContext, v8::Local<v8::Object>::Cast(callerFrame)); |
+ return JavaScriptCallFrame::create(debuggerContext, v8::Local<v8::Object>::Cast(callerFrame)); |
} |
int JavaScriptCallFrame::callV8FunctionReturnInt(const char* name) const |
{ |
v8::HandleScope handleScope(m_isolate); |
- v8::Context::Scope contextScope(v8::Local<v8::Context>::New(m_isolate, m_debuggerContext)); |
+ v8::Local<v8::Context> context = v8::Local<v8::Context>::New(m_isolate, m_debuggerContext); |
+ v8::Context::Scope contextScope(context); |
v8::Local<v8::Object> callFrame = v8::Local<v8::Object>::New(m_isolate, m_callFrame); |
v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(callFrame->Get(toV8StringInternalized(m_isolate, name))); |
v8::Local<v8::Value> result; |
- if (!m_client->callInternalFunction(func, callFrame, 0, nullptr).ToLocal(&result) || !result->IsInt32()) |
+ if (!func->Call(context, callFrame, 0, nullptr).ToLocal(&result) || !result->IsInt32()) |
return 0; |
return result.As<v8::Int32>()->Value(); |
} |
@@ -75,11 +74,12 @@ int JavaScriptCallFrame::callV8FunctionReturnInt(const char* name) const |
String JavaScriptCallFrame::callV8FunctionReturnString(const char* name) const |
{ |
v8::HandleScope handleScope(m_isolate); |
- v8::Context::Scope contextScope(v8::Local<v8::Context>::New(m_isolate, m_debuggerContext)); |
+ v8::Local<v8::Context> context = v8::Local<v8::Context>::New(m_isolate, m_debuggerContext); |
+ v8::Context::Scope contextScope(context); |
v8::Local<v8::Object> callFrame = v8::Local<v8::Object>::New(m_isolate, m_callFrame); |
v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(callFrame->Get(toV8StringInternalized(m_isolate, name))); |
v8::Local<v8::Value> result; |
- if (!m_client->callInternalFunction(func, callFrame, 0, nullptr).ToLocal(&result)) |
+ if (!func->Call(context, callFrame, 0, nullptr).ToLocal(&result)) |
return String(); |
return toWTFStringWithTypeCheck(result); |
} |
@@ -123,7 +123,7 @@ v8::Local<v8::Value> JavaScriptCallFrame::scopeChain() const |
{ |
v8::Local<v8::Object> callFrame = v8::Local<v8::Object>::New(m_isolate, m_callFrame); |
v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(callFrame->Get(toV8StringInternalized(m_isolate, "scopeChain"))); |
- v8::Local<v8::Array> scopeChain = v8::Local<v8::Array>::Cast(m_client->callInternalFunction(func, callFrame, 0, nullptr).ToLocalChecked()); |
+ v8::Local<v8::Array> scopeChain = v8::Local<v8::Array>::Cast(func->Call(m_isolate->GetCurrentContext(), callFrame, 0, nullptr).ToLocalChecked()); |
v8::Local<v8::Array> result = v8::Array::New(m_isolate, scopeChain->Length()); |
for (uint32_t i = 0; i < scopeChain->Length(); i++) |
result->Set(i, scopeChain->Get(i)); |
@@ -134,7 +134,7 @@ int JavaScriptCallFrame::scopeType(int scopeIndex) const |
{ |
v8::Local<v8::Object> callFrame = v8::Local<v8::Object>::New(m_isolate, m_callFrame); |
v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(callFrame->Get(toV8StringInternalized(m_isolate, "scopeType"))); |
- v8::Local<v8::Array> scopeType = v8::Local<v8::Array>::Cast(m_client->callInternalFunction(func, callFrame, 0, nullptr).ToLocalChecked()); |
+ v8::Local<v8::Array> scopeType = v8::Local<v8::Array>::Cast(func->Call(m_isolate->GetCurrentContext(), callFrame, 0, nullptr).ToLocalChecked()); |
return scopeType->Get(scopeIndex)->Int32Value(); |
} |
@@ -142,7 +142,7 @@ v8::Local<v8::String> JavaScriptCallFrame::scopeName(int scopeIndex) const |
{ |
v8::Local<v8::Object> callFrame = v8::Local<v8::Object>::New(m_isolate, m_callFrame); |
v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(callFrame->Get(toV8StringInternalized(m_isolate, "scopeName"))); |
- v8::Local<v8::Array> scopeType = v8::Local<v8::Array>::Cast(m_client->callInternalFunction(func, callFrame, 0, nullptr).ToLocalChecked()); |
+ v8::Local<v8::Array> scopeType = v8::Local<v8::Array>::Cast(func->Call(m_isolate->GetCurrentContext(), callFrame, 0, nullptr).ToLocalChecked()); |
return scopeType->Get(scopeIndex)->ToString(); |
} |
@@ -160,7 +160,7 @@ v8::Local<v8::Value> JavaScriptCallFrame::callScopeLocationFunction(const char* |
{ |
v8::Local<v8::Object> callFrame = v8::Local<v8::Object>::New(m_isolate, m_callFrame); |
v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(callFrame->Get(toV8StringInternalized(m_isolate, name))); |
- v8::Local<v8::Array> locations = v8::Local<v8::Array>::Cast(m_client->callInternalFunction(func, callFrame, 0, nullptr).ToLocalChecked()); |
+ v8::Local<v8::Array> locations = v8::Local<v8::Array>::Cast(func->Call(m_isolate->GetCurrentContext(), callFrame, 0, nullptr).ToLocalChecked()); |
return locations->Get(scopeIndex); |
} |
@@ -200,7 +200,7 @@ v8::Local<v8::Value> JavaScriptCallFrame::evaluateWithExceptionDetails(v8::Local |
v8::TryCatch tryCatch(m_isolate); |
v8::Local<v8::Object> wrappedResult = v8::Object::New(m_isolate); |
v8::Local<v8::Value> result; |
- if (m_client->callInternalFunction(evalFunction, callFrame, WTF_ARRAY_LENGTH(argv), argv).ToLocal(&result)) { |
+ if (evalFunction->Call(m_isolate->GetCurrentContext(), callFrame, WTF_ARRAY_LENGTH(argv), argv).ToLocal(&result)) { |
wrappedResult->Set(v8::String::NewFromUtf8(m_isolate, "result"), result); |
wrappedResult->Set(v8::String::NewFromUtf8(m_isolate, "exceptionDetails"), v8::Undefined(m_isolate)); |
} else { |
@@ -215,7 +215,7 @@ v8::MaybeLocal<v8::Value> JavaScriptCallFrame::restart() |
v8::Local<v8::Object> callFrame = v8::Local<v8::Object>::New(m_isolate, m_callFrame); |
v8::Local<v8::Function> restartFunction = v8::Local<v8::Function>::Cast(callFrame->Get(toV8StringInternalized(m_isolate, "restart"))); |
v8::Debug::SetLiveEditEnabled(m_isolate, true); |
- v8::MaybeLocal<v8::Value> result = m_client->callInternalFunction(restartFunction, callFrame, 0, nullptr); |
+ v8::MaybeLocal<v8::Value> result = restartFunction->Call(m_isolate->GetCurrentContext(), callFrame, 0, nullptr); |
v8::Debug::SetLiveEditEnabled(m_isolate, false); |
return result; |
} |
@@ -229,7 +229,7 @@ v8::MaybeLocal<v8::Value> JavaScriptCallFrame::setVariableValue(int scopeNumber, |
variableName, |
newValue |
}; |
- return m_client->callInternalFunction(setVariableValueFunction, callFrame, WTF_ARRAY_LENGTH(argv), argv); |
+ return setVariableValueFunction->Call(m_isolate->GetCurrentContext(), callFrame, WTF_ARRAY_LENGTH(argv), argv); |
} |
v8::Local<v8::Object> JavaScriptCallFrame::createExceptionDetails(v8::Isolate* isolate, v8::Local<v8::Message> message) |