components/guest_view/renderer/guest_view_request.cc - Issue 1769273004: Remove V8RecrusionScope, cleanup call sites.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/renderer/guest_view_request.cc

Issue 1769273004: Remove V8RecrusionScope, cleanup call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/guest_view/renderer/guest_view_request.cc

diff --git a/components/guest_view/renderer/guest_view_request.cc b/components/guest_view/renderer/guest_view_request.cc

index d0aa0611aa5d2607d8a194f6e64c7b5dc9640e82..fead0c5f06a7321ce221095ae617d6a013b53940 100644

--- a/components/guest_view/renderer/guest_view_request.cc

+++ b/components/guest_view/renderer/guest_view_request.cc

@@ -13,7 +13,6 @@

#include "content/public/renderer/render_view.h"

#include "third_party/WebKit/public/web/WebLocalFrame.h"

#include "third_party/WebKit/public/web/WebRemoteFrame.h"

-#include "third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h"

#include "third_party/WebKit/public/web/WebView.h"

namespace guest_view {

@@ -43,7 +42,8 @@ void GuestViewRequest::ExecuteCallbackIfAvailable(

return;

v8::Context::Scope context_scope(context);

- blink::WebScopedMicrotaskSuppression suppression;

+ v8::MicrotasksScope microtasks(

+ isolate(), v8::MicrotasksScope::kDoNotRunMicrotasks);

callback->Call(context->Global(), argc, argv.get());

}