Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h

Issue 1769273004: Remove V8RecrusionScope, cleanup call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments, a couple more tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 class V8DebuggerClient; 44 class V8DebuggerClient;
45 class V8DebuggerImpl; 45 class V8DebuggerImpl;
46 46
47 class InjectedScriptManager { 47 class InjectedScriptManager {
48 PROTOCOL_DISALLOW_COPY(InjectedScriptManager); 48 PROTOCOL_DISALLOW_COPY(InjectedScriptManager);
49 public: 49 public:
50 static PassOwnPtr<InjectedScriptManager> create(V8DebuggerImpl*); 50 static PassOwnPtr<InjectedScriptManager> create(V8DebuggerImpl*);
51 ~InjectedScriptManager(); 51 ~InjectedScriptManager();
52 52
53 InjectedScriptHost* injectedScriptHost(); 53 InjectedScriptHost* injectedScriptHost();
54 V8DebuggerImpl* debugger() { return m_debugger; }
54 55
55 InjectedScript* injectedScriptFor(v8::Local<v8::Context>); 56 InjectedScript* injectedScriptFor(v8::Local<v8::Context>);
56 InjectedScript* findInjectedScript(int) const; 57 InjectedScript* findInjectedScript(int) const;
57 InjectedScript* findInjectedScript(RemoteObjectIdBase*) const; 58 InjectedScript* findInjectedScript(RemoteObjectIdBase*) const;
58 void discardInjectedScripts(); 59 void discardInjectedScripts();
59 int discardInjectedScriptFor(v8::Local<v8::Context>); 60 int discardInjectedScriptFor(v8::Local<v8::Context>);
60 void discardInjectedScript(int); 61 void discardInjectedScript(int);
61 void releaseObjectGroup(const String& objectGroup); 62 void releaseObjectGroup(const String& objectGroup);
62 void setCustomObjectFormatterEnabled(bool); 63 void setCustomObjectFormatterEnabled(bool);
63 64
64 private: 65 private:
65 explicit InjectedScriptManager(V8DebuggerImpl*); 66 explicit InjectedScriptManager(V8DebuggerImpl*);
66 67
67 v8::Local<v8::Object> createInjectedScript(const String& source, v8::Local<v 8::Context>, int id, InjectedScriptNative*); 68 v8::Local<v8::Object> createInjectedScript(const String& source, v8::Local<v 8::Context>, int id, InjectedScriptNative*);
68 69
69 typedef protocol::HashMap<int, OwnPtr<InjectedScript>> IdToInjectedScriptMap ; 70 typedef protocol::HashMap<int, OwnPtr<InjectedScript>> IdToInjectedScriptMap ;
70 IdToInjectedScriptMap m_idToInjectedScript; 71 IdToInjectedScriptMap m_idToInjectedScript;
71 OwnPtr<InjectedScriptHost> m_injectedScriptHost; 72 OwnPtr<InjectedScriptHost> m_injectedScriptHost;
72 bool m_customObjectFormatterEnabled; 73 bool m_customObjectFormatterEnabled;
73 V8DebuggerClient* m_client; 74 V8DebuggerImpl* m_debugger;
74 }; 75 };
75 76
76 } // namespace blink 77 } // namespace blink
77 78
78 #endif // !defined(InjectedScriptManager_h) 79 #endif // !defined(InjectedScriptManager_h)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698