Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 1769273004: Remove V8RecrusionScope, cleanup call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
462 var uiLocation = WebInspector.debuggerWorkspaceBinding.rawLocationToUILo cation(rawLocation); 462 var uiLocation = WebInspector.debuggerWorkspaceBinding.rawLocationToUILo cation(rawLocation);
463 return uiLocation.linkText(); 463 return uiLocation.linkText();
464 } 464 }
465 465
466 /** 466 /**
467 * @return {?string} 467 * @return {?string}
468 */ 468 */
469 function linkifyTopCallFrameAsText() 469 function linkifyTopCallFrameAsText()
470 { 470 {
471 var frame = WebInspector.TimelineUIUtils.topStackFrame(event); 471 var frame = WebInspector.TimelineUIUtils.topStackFrame(event);
472 return frame ? linkifyLocationAsText(frame.scriptId, frame.lineNumber, f rame.columnNumber) : null; 472 var text = frame ? linkifyLocationAsText(frame.scriptId, frame.lineNumbe r, frame.columnNumber) : null;
473 if (frame && !text) {
474 text = frame.url;
475 if (typeof frame.lineNumber === "number")
476 text += ":" + (frame.lineNumber + 1);
477 }
478 return text;
473 } 479 }
474 } 480 }
475 481
476 /** 482 /**
477 * @param {!WebInspector.TracingModel.Event} event 483 * @param {!WebInspector.TracingModel.Event} event
478 * @param {?WebInspector.Target} target 484 * @param {?WebInspector.Target} target
479 * @param {!WebInspector.Linkifier} linkifier 485 * @param {!WebInspector.Linkifier} linkifier
480 * @return {?Node} 486 * @return {?Node}
481 */ 487 */
482 WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent = function(event, tar get, linkifier) 488 WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent = function(event, tar get, linkifier)
(...skipping 1611 matching lines...) Expand 10 before | Expand all | Expand 10 after
2094 case warnings.V8Deopt: 2100 case warnings.V8Deopt:
2095 span.appendChild(WebInspector.linkifyURLAsNode("https://github.com/Googl eChrome/devtools-docs/issues/53", 2101 span.appendChild(WebInspector.linkifyURLAsNode("https://github.com/Googl eChrome/devtools-docs/issues/53",
2096 WebInspector.UIString("Not optimized"), undefined, true)); 2102 WebInspector.UIString("Not optimized"), undefined, true));
2097 span.createTextChild(WebInspector.UIString(": %s", eventData["deoptReaso n"])); 2103 span.createTextChild(WebInspector.UIString(": %s", eventData["deoptReaso n"]));
2098 break; 2104 break;
2099 default: 2105 default:
2100 console.assert(false, "Unhandled TimelineModel.WarningType"); 2106 console.assert(false, "Unhandled TimelineModel.WarningType");
2101 } 2107 }
2102 return span; 2108 return span;
2103 } 2109 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698