Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: pkg/analyzer/lib/src/generated/error_verifier.dart

Issue 1769253002: Fix cycle in override check. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/error_verifier.dart
diff --git a/pkg/analyzer/lib/src/generated/error_verifier.dart b/pkg/analyzer/lib/src/generated/error_verifier.dart
index d6c90a1690012d6b472a085baef2f2a28fa938bd..70aa151cd7bd61ecdba7c55b6ccd368b9666745c 100644
--- a/pkg/analyzer/lib/src/generated/error_verifier.dart
+++ b/pkg/analyzer/lib/src/generated/error_verifier.dart
@@ -5802,12 +5802,15 @@ class ErrorVerifier extends RecursiveAstVisitor<Object> {
MethodElement _findOverriddenMemberThatMustCallSuper(MethodDeclaration node) {
ExecutableElement overriddenMember = _getOverriddenMember(node.element);
- while (overriddenMember is MethodElement) {
+ List<ExecutableElement> seen = <ExecutableElement>[];
+ while (
+ overriddenMember is MethodElement && !seen.contains(overriddenMember)) {
for (ElementAnnotation annotation in overriddenMember.metadata) {
if (annotation.isMustCallSuper) {
return overriddenMember;
}
}
+ seen.add(overriddenMember);
// Keep looking up the chain.
overriddenMember = _getOverriddenMember(overriddenMember);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698