Issue 176923018: Revert 253259 "Move ContextProvider binding to inside GpuVideoAc..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 176923018: Revert 253259 "Move ContextProvider binding to inside GpuVideoAc..." (Closed)

Created:
6 years, 9 months ago by Peter Kasting

Modified:
6 years, 9 months ago

Reviewers:
sheu1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 253259 "Move ContextProvider binding to inside GpuVideoAc..." Broke 100+ WebKit layout tests. > Move ContextProvider binding to inside GpuVideoAcceleratorFactory > > Bind the ContextProvider inside the GpuVideoAcceleratorFactory itself, so the > Factory can decide appropriately what to do in casae of binding failure. > > Also: replace references to RendererGpuVideoAcceleratorFactory with references > to its superclass, GpuVideoAcceleratorFactory. > > BUG=345424 > TEST=local build on desktop Linux > R=avi@chromium.org, fischman@chromium.org > > Review URL: https://codereview.chromium.org/171773014 TBR=sheu@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253326

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -27 lines)			Patch
M	trunk/src/content/public/renderer/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/content/public/renderer/video_encode_accelerator.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	trunk/src/content/renderer/media/media_stream_dependency_factory.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/renderer/media/renderer_gpu_video_accelerator_factories.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/content/renderer/media/renderer_gpu_video_accelerator_factories.cc	View	2 chunks	+2 lines, -13 lines	0 comments	Download
M	trunk/src/content/renderer/render_thread_impl.h	View	3 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/content/renderer/render_thread_impl.cc	View	3 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r253326.

Expand Messages | Collapse Messages