Chromium Code Reviews| Index: native_client_sdk/src/libraries/nacl_io/kernel_wrap_real.h |
| diff --git a/native_client_sdk/src/libraries/nacl_io/kernel_wrap_real.h b/native_client_sdk/src/libraries/nacl_io/kernel_wrap_real.h |
| index f46f6cc5479b0c2da973c084e137601acae03bab..68e3345f37805746d696747ad3d44306e5feac9c 100644 |
| --- a/native_client_sdk/src/libraries/nacl_io/kernel_wrap_real.h |
| +++ b/native_client_sdk/src/libraries/nacl_io/kernel_wrap_real.h |
| @@ -11,15 +11,16 @@ |
| EXTERN_C_BEGIN |
| +/* NOTE: We do not use off_t because it may be 32 or 64 bit */ |
|
Sam Clegg
2014/03/27 00:10:02
Can you use a typedef here to signal the intent (p
noelallen1
2014/03/27 18:13:48
Initially I had off64_t but got push from core. I
Sam Clegg
2014/03/27 18:18:32
Can we just use nacl_io_off_t then? just a nacl_
Sam Clegg
2014/04/03 18:57:34
Ping?
Can we typedef this? Even if you just use i
|
| int _real_close(int fd); |
| void _real_exit(int status); |
| int _real_fstat(int fd, struct stat *buf); |
| int _real_getdents(int fd, void* nacl_buf, size_t nacl_count, size_t *nread); |
| int _real_isatty(int fd, int* result); |
| -int _real_lseek(int fd, off_t offset, int whence, off_t* new_offset); |
| +int _real_lseek(int fd, int64_t offset, int whence, int64_t* new_offset); |
| int _real_mkdir(const char* pathname, mode_t mode); |
| int _real_mmap(void** addr, size_t length, int prot, int flags, int fd, |
| - off_t offset); |
| + int64_t offset); |
| int _real_munmap(void* addr, size_t length); |
| int _real_open(const char* pathname, int oflag, mode_t cmode, int* newfd); |
| int _real_open_resource(const char* file, int* fd); |