[NaCl SDK] Compile for naclio for Bionic

native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "nacl_io/socket/socket_node.h"
 
 #include "nacl_io/ossocket.h"
 #ifdef PROVIDES_SOCKET_API
 
 #include <errno.h>
@@ skipping 258 matching lines @@
   if (lvl != SOL_SOCKET)
     return ENOPROTOOPT;
 
   AUTO_LOCK(node_lock_);
 
   switch (optname) {
     case SO_REUSEADDR: {
       // SO_REUSEADDR is effectivly always on since we can't
       // disable it with PPAPI sockets. Just return success
       // here regardless.
-      if (len < sizeof(int))
+      if (static_cast<size_t>(len) < sizeof(int))

[binji, 2014/04/02 18:35:53]

Might be nicer to do this once at the top of the function, and mention why. What
is the size of socklen_t on bionic?

[noelallen1, 2014/04/03 17:58:52]

It's a different type, not size.

         return EINVAL;
       return 0;
     }
     case SO_LINGER: {
       // Not supported by the PPAPI interface but we preserve
       // the settings and pretend to support it.
-      if (len < sizeof(struct linger))
+      if (static_cast<size_t>(len) < sizeof(struct linger))
         return EINVAL;
       struct linger new_linger = *static_cast<const linger*>(optval);
       // Don't allow setting linger to be enabled until we
       // implement the required synchronous shutdown()/close().
       // TODO(sbc): remove this after http://crbug.com/312401
       // gets fixed.
       if (new_linger.l_onoff != 0)
         return EINVAL;
       linger_ = new_linger;
       return 0;
     }
     case SO_KEEPALIVE: {
       // Not supported by the PPAPI interface but we preserve
       // the flag and pretend to support it.
-      if (len < sizeof(int))
+      if (static_cast<size_t>(len) < sizeof(int))
         return EINVAL;
       int value = *static_cast<const int*>(optval);
       keep_alive_ = value != 0;
       return 0;
     }
   }
 
   return ENOPROTOOPT;
 }
 
@@ skipping 155 matching lines @@
     return 0;
   }
 
   *len = ResourceToSockAddr(local_addr_, *len, addr);
   return 0;
 }
 
 }  // namespace nacl_io
 
 #endif  // PROVIDES_SOCKET_API