[NaCl SDK] Compile for naclio for Bionic

native_client_sdk/src/build_tools/build_projects.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import multiprocessing
 import optparse
 import os
 import posixpath
 import sys
@@ skipping 11 matching lines @@
 sys.path.append(os.path.join(SDK_SRC_DIR, 'tools'))
 import getos
 
 
 MAKE = 'nacl_sdk/make_3.99.90-26-gf80222c/make.exe'
 LIB_DICT = {
   'linux': [],
   'mac': [],
   'win': ['x86_32']
 }
+

[Sam Clegg, 2014/03/27 00:10:02]

Extra newline here for some reason?

[noelallen1, 2014/03/27 18:13:48]

Done.

 VALID_TOOLCHAINS = [
   'bionic',
   'newlib',
   'glibc',
   'pnacl',
   'win',
   'linux',
   'mac',
 ]
 
@@ skipping 136 matching lines @@
     # build.
     env['X86_32_CFLAGS'] = '-m32'
     env['X86_32_CXXFLAGS'] = '-m32'
     jobs = '50'
   else:
     jobs = str(multiprocessing.cpu_count())
 
   make_cmd = [make, '-j', jobs]
 
   make_cmd.append('CONFIG='+config)
+  make_cmd.append('ENABLE_BIONIC=1')

[Sam Clegg, 2014/03/27 00:10:02]

Is it OK to add this unconditionally?

[noelallen1, 2014/03/27 18:13:48]

Yes, every project we provide overrides the VALID_TOOLCHAINS

ifneq ($(ENABLE_BIONIC),)
ALL_TOOLCHAINS ?= pnacl newlib glibc bionic
else
ALL_TOOLCHAINS ?= pnacl newlib glibc
endif

...

So for some example:
VALID_TOOLCHAINS := newlib glibc pnacl linux

#
# The target for all versions
#
USABLE_TOOLCHAINS=$(filter $(OSNAME) $(ALL_TOOLCHAINS), $(VALID_TOOLCHAINS))

If bionic is not enabled, then the project generator will not add bionic to the
list of possible targets.

   if not deps:
     make_cmd.append('IGNORE_DEPS=1')
 
   if verbose:
     make_cmd.append('V=1')
 
   if args:
     make_cmd += args
   else:
     make_cmd.append('TOOLCHAIN=all')
@@ skipping 19 matching lines @@
 def main(argv):
   parser = optparse.OptionParser()
   parser.add_option('-c', '--clobber',
       help='Clobber project directories before copying new files',
       action='store_true', default=False)
   parser.add_option('-b', '--build',
       help='Build the projects.', action='store_true')
   parser.add_option('--config',
       help='Choose configuration to build (Debug or Release).  Builds both '
            'by default')
+  parser.add_option('--bionic',
+      help='Enable bionic projects', action='store_true')
   parser.add_option('-x', '--experimental',
       help='Build experimental projects', action='store_true')
   parser.add_option('-t', '--toolchain',
       help='Build using toolchain. Can be passed more than once.',
       action='append', default=[])
   parser.add_option('-d', '--dest',
       help='Select which build destinations (project types) are valid.',
       action='append')
   parser.add_option('-v', '--verbose', action='store_true')
 
@@ skipping 15 matching lines @@
 
   pepper_ver = str(int(build_version.ChromeMajorVersion()))
   pepperdir = os.path.join(OUT_DIR, 'pepper_' + pepper_ver)
 
   if not options.toolchain:
     # Order matters here: the default toolchain for an example's Makefile will
     # be the first toolchain in this list that is available in the example.
     # e.g. If an example supports newlib and glibc, then the default will be
     # newlib.
     options.toolchain = ['pnacl', 'newlib', 'glibc', 'host']
-    if options.experimental:
+    if options.experimental or options.bionic:
       options.toolchain.append('bionic')
 
   if 'host' in options.toolchain:
     options.toolchain.remove('host')
     options.toolchain.append(getos.GetPlatform())
     print 'Adding platform: ' + getos.GetPlatform()
 
   ValidateToolchains(options.toolchain)
 
   filters = {}
@@ skipping 35 matching lines @@
 
 
 if __name__ == '__main__':
   script_name = os.path.basename(sys.argv[0])
   try:
     sys.exit(main(sys.argv))
   except parse_dsc.ValidationError as e:
     buildbot_common.ErrorExit('%s: %s' % (script_name, e))
   except KeyboardInterrupt:
     buildbot_common.ErrorExit('%s: interrupted' % script_name)