third_party/sqlite/amalgamation/sqlite3.c - Issue 1769213002: [sqlite] Fix seperate-page-cache page merge issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/sqlite/amalgamation/sqlite3.c

Issue 1769213002: [sqlite] Fix seperate-page-cache page merge issue. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/sqlite/amalgamation/sqlite3.c

diff --git a/third_party/sqlite/amalgamation/sqlite3.c b/third_party/sqlite/amalgamation/sqlite3.c

index 46a2b2c30a8a2003ba8419e948ff06816d918b0c..cfa2363f79967c446a6f574a34dc56b7fe4e7567 100644

--- a/third_party/sqlite/amalgamation/sqlite3.c

+++ b/third_party/sqlite/amalgamation/sqlite3.c

@@ -42305,7 +42305,7 @@ static int pcache1Init(void *NotUsed){

** * Otherwise use separate caches (mode-1)

#ifdef SQLITE_SEPARATE_CACHE_POOLS

- const int separateCache = 1;

Alexander Potapenko 2016/03/10 16:37:42 Dumb question: this line didn't touch pcache1_g, h

Scott Hess - ex-Googler 2016/03/10 16:56:45 separate-cache means that each db connection has a

+ pcache1.separateCache = 1;

#elif defined(SQLITE_ENABLE_MEMORY_MANAGEMENT)

pcache1.separateCache = 0;

#elif SQLITE_THREADSAFE

« no previous file with comments | « no previous file | third_party/sqlite/patches/0002-Use-seperate-page-cache-pools-for-each-sqlite-connec.patch » ('j') | no next file with comments »