Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Side by Side Diff: runtime/vm/dart_api_impl.cc

Issue 1769183003: Fix sticky error propagation from thread to isolate (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/isolate.cc » ('j') | runtime/vm/isolate.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "include/dart_api.h" 5 #include "include/dart_api.h"
6 #include "include/dart_mirrors_api.h" 6 #include "include/dart_mirrors_api.h"
7 #include "include/dart_native_api.h" 7 #include "include/dart_native_api.h"
8 8
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 #include "lib/stacktrace.h" 10 #include "lib/stacktrace.h"
(...skipping 1609 matching lines...) Expand 10 before | Expand all | Expand 10 after
1620 data.monitor = &monitor; 1620 data.monitor = &monitor;
1621 data.done = false; 1621 data.done = false;
1622 I->message_handler()->Run( 1622 I->message_handler()->Run(
1623 Dart::thread_pool(), 1623 Dart::thread_pool(),
1624 NULL, RunLoopDone, reinterpret_cast<uword>(&data)); 1624 NULL, RunLoopDone, reinterpret_cast<uword>(&data));
1625 while (!data.done) { 1625 while (!data.done) {
1626 ml.Wait(); 1626 ml.Wait();
1627 } 1627 }
1628 } 1628 }
1629 ::Dart_EnterIsolate(Api::CastIsolate(I)); 1629 ::Dart_EnterIsolate(Api::CastIsolate(I));
1630 if (T->sticky_error() != Object::null()) { 1630 T = Thread::Current();
1631 Dart_Handle error = Api::NewHandle(T, T->sticky_error()); 1631 if (I->object_store()->sticky_error() != Object::null()) {
1632 T->clear_sticky_error(); 1632 Dart_Handle error = Api::NewHandle(T, I->object_store()->sticky_error());
1633 I->object_store()->clear_sticky_error();
1633 return error; 1634 return error;
1634 } 1635 }
1635 if (FLAG_print_class_table) { 1636 if (FLAG_print_class_table) {
1636 HANDLESCOPE(T); 1637 HANDLESCOPE(T);
1637 I->class_table()->Print(); 1638 I->class_table()->Print();
1638 } 1639 }
1639 return Api::Success(); 1640 return Api::Success();
1640 } 1641 }
1641 1642
1642 1643
(...skipping 4551 matching lines...) Expand 10 before | Expand all | Expand 10 after
6194 return Api::Success(); 6195 return Api::Success();
6195 } 6196 }
6196 #endif // DART_PRECOMPILER 6197 #endif // DART_PRECOMPILER
6197 6198
6198 6199
6199 DART_EXPORT bool Dart_IsRunningPrecompiledCode() { 6200 DART_EXPORT bool Dart_IsRunningPrecompiledCode() {
6200 return Dart::IsRunningPrecompiledCode(); 6201 return Dart::IsRunningPrecompiledCode();
6201 } 6202 }
6202 6203
6203 } // namespace dart 6204 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/isolate.cc » ('j') | runtime/vm/isolate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698