Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1769163006: nanobench: turn on f16 and sRGB on the bots (Closed)

Created:
4 years, 9 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M tools/nanobench_flags.json View 8 chunks +16 lines, -0 lines 0 comments Download
M tools/nanobench_flags.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769163006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769163006/1
4 years, 9 months ago (2016-03-08 19:35:38 UTC) #4
mtklein_C
4 years, 9 months ago (2016-03-08 20:14:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769163006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769163006/1
4 years, 9 months ago (2016-03-08 20:14:32 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-08 20:14:33 UTC) #10
reed1
lgtm
4 years, 9 months ago (2016-03-08 20:32:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769163006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769163006/1
4 years, 9 months ago (2016-03-08 20:33:05 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/6b5c5cc7b7bdffb4882706b915b544aba8714961
4 years, 9 months ago (2016-03-08 20:34:14 UTC) #16
mtklein
4 years, 9 months ago (2016-03-08 21:25:27 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1780463003/ by mtklein@google.com.

The reason for reverting is: Debug bots failing at
   Running writepix_RGBA_UPM	f16

../../../src/core/SkBitmap.cpp:558: fatal error: ""false && \"Can't return addr
for config\"""
.

Powered by Google App Engine
This is Rietveld 408576698