Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1769083003: ARC: Add network GUID to the metadata that is sent to the Host. (Closed)

Created:
4 years, 9 months ago by abhishekbh
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ARC: Add network GUID to the metadata that is sent to the Host. This change adds a network's GUID, as assigned by the Host, to the output struct that is sent to the Host when it queries for visible or configured networks. BUG=592882 BUG=b/27462412 Committed: https://crrev.com/3e0f8c53614852fdcede6e96a0badb4dbd09844a Cr-Commit-Position: refs/heads/master@{#379956}

Patch Set 1 #

Patch Set 2 : Fixed typo in commit description. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M components/arc/common/net.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M components/arc/net/arc_net_host_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
abhishekbh
PTAL.
4 years, 9 months ago (2016-03-08 05:08:23 UTC) #2
Kevin Cernekee
Changelog should say "sent to ARC" instead of "to host"? Otherwise LGTM
4 years, 9 months ago (2016-03-08 05:15:56 UTC) #4
dcheng
lgtm
4 years, 9 months ago (2016-03-08 07:13:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769083003/20001
4 years, 9 months ago (2016-03-08 19:17:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/154469)
4 years, 9 months ago (2016-03-08 19:31:03 UTC) #10
abhishekbh
Presubmit failed due to owner missing. Added Elijah. PTAL.
4 years, 9 months ago (2016-03-08 19:47:01 UTC) #12
elijahtaylor1
lgtm
4 years, 9 months ago (2016-03-08 22:55:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769083003/20001
4 years, 9 months ago (2016-03-08 22:59:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769083003/20001
4 years, 9 months ago (2016-03-08 23:00:18 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 23:04:58 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 23:06:14 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e0f8c53614852fdcede6e96a0badb4dbd09844a
Cr-Commit-Position: refs/heads/master@{#379956}

Powered by Google App Engine
This is Rietveld 408576698