Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1485)

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

Issue 1769063002: Remove SearchEngine.searchElementDeclarations(). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart b/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
index 43a0a351b947f763636e4034b07c2598a3f4a198..46ed17360ad8e65d66137c9cfcb8dffe62093989 100644
--- a/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
@@ -135,7 +135,27 @@ main(A a) {
expectedMessage: "Renamed method will be invisible in 'my.lib'.");
}
- test_checkFinalConditions_shadowed_byLocal_inSameClass() async {
+ test_checkFinalConditions_shadowed_byLocalFunction_inSameClass() async {
+ indexTestUnit('''
+class A {
+ test() {}
+ main() {
+ newName() {}
+ test(); // marker
+ }
+}
+''');
+ createRenameRefactoringAtString('test() {}');
+ // check status
+ refactoring.newName = 'newName';
+ RefactoringStatus status = await refactoring.checkFinalConditions();
+ assertRefactoringStatus(status, RefactoringProblemSeverity.ERROR,
+ expectedMessage:
+ "Usage of renamed method will be shadowed by function 'newName'.",
+ expectedContextSearch: 'test(); // marker');
+ }
+
+ test_checkFinalConditions_shadowed_byLocalVariable_inSameClass() async {
indexTestUnit('''
class A {
test() {}
@@ -155,7 +175,7 @@ class A {
expectedContextSearch: 'test(); // marker');
}
- test_checkFinalConditions_shadowed_byLocal_inSubClass() async {
+ test_checkFinalConditions_shadowed_byLocalVariable_inSubClass() async {
indexTestUnit('''
class A {
test() {}
@@ -177,7 +197,7 @@ class B extends A {
expectedContextSearch: 'test(); // marker');
}
- test_checkFinalConditions_shadowed_byLocal_OK_qualifiedReference() async {
+ test_checkFinalConditions_shadowed_byLocalVariable_OK_qualifiedReference() async {
indexTestUnit('''
class A {
test() {}
@@ -194,7 +214,7 @@ class A {
assertRefactoringStatusOK(status);
}
- test_checkFinalConditions_shadowed_byLocal_OK_renamedNotUsed() async {
+ test_checkFinalConditions_shadowed_byLocalVariable_OK_renamedNotUsed() async {
indexTestUnit('''
class A {
test() {}

Powered by Google App Engine
This is Rietveld 408576698