Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Issue 1769043002: Don't assume that we always have a HowToFix and remove failing test. (Closed)

Created:
4 years, 9 months ago by floitsch
Modified:
4 years, 9 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't assume that we always have a HowToFix and remove failing test. Also fix a typo. Committed: https://github.com/dart-lang/sdk/commit/d41bce8cda6ca23ee5e1ae917c4d8f05d3a4e0a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/dart_messages/lib/generated/shared_messages.json View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/dart_messages/lib/shared_messages.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/message_kind_helper.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
floitsch
TBR.
4 years, 9 months ago (2016-03-07 16:36:07 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as d41bce8cda6ca23ee5e1ae917c4d8f05d3a4e0a2 (presubmit successful).
4 years, 9 months ago (2016-03-07 16:36:40 UTC) #5
Johnni Winther
4 years, 9 months ago (2016-03-08 08:06:19 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698