Drop the PRE_SAFE/POST_SAFE distinction.

Drop the PRE_SAFE/POST_SAFE distinction.

I don't think anyone is looking at this data, and it's marginally less
complicated to ignore the distinction.

R=rdsmith@chromium.org

Committed: https://crrev.com/aa07ee8fed46667cd71d8025dac4a7c3862b573b
Cr-Commit-Position: refs/heads/master@{#380641}

[Mike West, 2016-03-08 08:57:45]

Randy, WDYT?

[Randy Smith (Not in Mondays), 2016-03-08 16:24:19]

LGTM.  I'm certainly with you that no-one is looking at these :-}.  I think this
was added when we added the per-domain eviction and wanted to see how much extra
we flushed that would have been kept before per-domain eviction.  But I don't
think we ever looked at it.

[Mike West, 2016-03-08 16:32:21]

On 2016/03/08 at 16:24:19, rdsmith wrote:
> LGTM.  I'm certainly with you that no-one is looking at these :-}.  I think
this was added when we added the per-domain eviction and wanted to see how much
extra we flushed that would have been kept before per-domain eviction.  But I
don't think we ever looked at it.

Great. I'll land this once https://codereview.chromium.org/1767513004/ is in.

There are a number of histograms here. I'm pretty sure that at least some of
them can go. Perhaps you could take a look at the other ones with your name on
them, and I'd be happy to throw you CLs to measure less.

[Randy Smith (Not in Mondays), 2016-03-08 18:09:05]

On 2016/03/08 16:32:21, Mike West wrote:
> On 2016/03/08 at 16:24:19, rdsmith wrote:
> > LGTM.  I'm certainly with you that no-one is looking at these :-}.  I think
> this was added when we added the per-domain eviction and wanted to see how
much
> extra we flushed that would have been kept before per-domain eviction.  But I
> don't think we ever looked at it.
> 
> Great. I'll land this once https://codereview.chromium.org/1767513004/ is in.
> 
> There are a number of histograms here. I'm pretty sure that at least some of
> them can go. Perhaps you could take a look at the other ones with your name on
> them, and I'd be happy to throw you CLs to measure less.

The problem is that, given that no-one is officially maintaining cookies, we
neither have anyone who'll look at anything we leave in, or anyone appropriate
to come up with a holistic vision for what set of measurements we should be
keeping.  Several of those histograms I inherited from Erik Wright when he left,
and really don't grok myself.  So doing a good, balancing trimming would take
more knowledge than I have.  

If you want a shoot from the hip judgement, I'd say we can nuke
Cookie.TimeKeyLoadTotalWait and Cookie.TimeLoad, but I can see the value in all
the other histos (and I may be dissing those histos just because I don't
completely grok the priority loading mechanism).

[Mike West, 2016-03-11 13:11:19]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2016-03-11 13:11:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1769023003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1769023003/1

[commit-bot: I haz the power, 2016-03-11 13:13:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 13:13:37]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mike West, 2016-03-11 13:58:18]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2016-03-11 13:58:19]

The patchset sent to the CQ was uploaded after l-g-t-m from rdsmith@chromium.org
Link to the patchset: https://codereview.chromium.org/1769023003/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-03-11 13:58:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1769023003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1769023003/20001

[commit-bot: I haz the power, 2016-03-11 15:32:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-11 15:33:56]

Description was changed from

==========
Drop the PRE_SAFE/POST_SAFE distinction.

I don't think anyone is looking at this data, and it's marginally less
complicated to ignore the distinction.

R=rdsmith@chromium.org
==========

to

==========
Drop the PRE_SAFE/POST_SAFE distinction.

I don't think anyone is looking at this data, and it's marginally less
complicated to ignore the distinction.

R=rdsmith@chromium.org

Committed: https://crrev.com/aa07ee8fed46667cd71d8025dac4a7c3862b573b
Cr-Commit-Position: refs/heads/master@{#380641}
==========

[commit-bot: I haz the power, 2016-03-11 15:33:57]

Patchset 2 (id:??) landed as
https://crrev.com/aa07ee8fed46667cd71d8025dac4a7c3862b573b
Cr-Commit-Position: refs/heads/master@{#380641}