Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart

Issue 1769013002: Add white-listing to sourcemap tests. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart
diff --git a/tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart b/tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart
index 5e5bb28a9ab9e0e7ab1645533a74fcfaaad02e8b..dce4d7c2bda26515fe5541b4f24fdacd0b70a597 100644
--- a/tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart
+++ b/tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart
@@ -505,10 +505,10 @@ class CodePointComputer extends TraceListener {
/// Called when [node] defines a step of the given [kind] at the given
/// [offset] when the generated JavaScript code.
void onStep(js.Node node, Offset offset, StepKind kind) {
- register('$kind', node);
+ register(kind, node);
}
- void register(String kind, js.Node node, {bool expectInfo: true}) {
+ void register(StepKind kind, js.Node node, {bool expectInfo: true}) {
String dartCodeFromSourceLocation(SourceLocation sourceLocation) {
SourceFile sourceFile =
@@ -555,7 +555,7 @@ class CodePointComputer extends TraceListener {
/// A JavaScript code point and its mapped dart source location.
class CodePoint {
- final String kind;
+ final StepKind kind;
final String jsCode;
final SourceLocation sourceLocation;
final String dartCode;

Powered by Google App Engine
This is Rietveld 408576698