Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1768993002: Update oauth2client to v2.0.1 and googleapiclient to v1.5.0.

Created:
4 years, 9 months ago by M-A Ruel
Modified:
4 years, 6 months ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, Lei Lei, regank_google.com, Vadim Sh.
Base URL:
git@github.com:luci/luci-py.git@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Update oauth2client to v2.0.1 and googleapiclient to v1.5.0. Remove stale copies from appengine/third_party/ to only keep one (up to date) copy. Temporarily patch ts_mon to make it compatible as oauth2client update is a breaking change. :( R=sergeyberezin@chromium.org BUG=chromium:593426

Patch Set 1 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1958 lines, -11234 lines) Patch
M appengine/swarming/server/bot_archive.py View 1 chunk +6 lines, -5 lines 0 comments Download
M appengine/third_party/gae_ts_mon/third_party/googleapiclient View 1 chunk +1 line, -1 line 0 comments Download
M appengine/third_party/gae_ts_mon/third_party/oauth2client View 1 chunk +1 line, -1 line 0 comments Download
D appengine/third_party/googleapiclient/README.swarming View 1 chunk +0 lines, -14 lines 0 comments Download
D appengine/third_party/googleapiclient/__init__.py View 1 chunk +0 lines, -15 lines 0 comments Download
D appengine/third_party/googleapiclient/channel.py View 1 chunk +0 lines, -285 lines 0 comments Download
D appengine/third_party/googleapiclient/discovery.py View 1 chunk +0 lines, -995 lines 0 comments Download
D appengine/third_party/googleapiclient/errors.py View 1 chunk +0 lines, -140 lines 0 comments Download
D appengine/third_party/googleapiclient/http.py View 1 chunk +0 lines, -1614 lines 0 comments Download
D appengine/third_party/googleapiclient/mimeparse.py View 1 chunk +0 lines, -172 lines 0 comments Download
D appengine/third_party/googleapiclient/model.py View 1 chunk +0 lines, -383 lines 0 comments Download
D appengine/third_party/googleapiclient/sample_tools.py View 1 chunk +0 lines, -102 lines 0 comments Download
D appengine/third_party/googleapiclient/schema.py View 1 chunk +0 lines, -311 lines 0 comments Download
D appengine/third_party/oauth2client/README.swarming View 1 chunk +0 lines, -13 lines 0 comments Download
D appengine/third_party/oauth2client/__init__.py View 1 chunk +0 lines, -8 lines 0 comments Download
D appengine/third_party/oauth2client/appengine.py View 1 chunk +0 lines, -989 lines 0 comments Download
D appengine/third_party/oauth2client/client.py View 1 chunk +0 lines, -1933 lines 0 comments Download
D appengine/third_party/oauth2client/clientsecrets.py View 1 chunk +0 lines, -151 lines 0 comments Download
D appengine/third_party/oauth2client/crypt.py View 1 chunk +0 lines, -409 lines 0 comments Download
D appengine/third_party/oauth2client/django_orm.py View 1 chunk +0 lines, -141 lines 0 comments Download
D appengine/third_party/oauth2client/file.py View 1 chunk +0 lines, -122 lines 0 comments Download
D appengine/third_party/oauth2client/gce.py View 1 chunk +0 lines, -105 lines 0 comments Download
D appengine/third_party/oauth2client/keyring_storage.py View 1 chunk +0 lines, -110 lines 0 comments Download
D appengine/third_party/oauth2client/locked_file.py View 1 chunk +0 lines, -376 lines 0 comments Download
D appengine/third_party/oauth2client/multistore_file.py View 1 chunk +0 lines, -463 lines 0 comments Download
D appengine/third_party/oauth2client/old_run.py View 1 chunk +0 lines, -161 lines 0 comments Download
D appengine/third_party/oauth2client/service_account.py View 1 chunk +0 lines, -138 lines 0 comments Download
D appengine/third_party/oauth2client/tools.py View 1 chunk +0 lines, -244 lines 0 comments Download
D appengine/third_party/oauth2client/util.py View 1 chunk +0 lines, -196 lines 0 comments Download
D appengine/third_party/oauth2client/xsrfutil.py View 1 chunk +0 lines, -118 lines 0 comments Download
A + client/third_party/googleapiclient/LICENSE View 1 chunk +1 line, -1 line 0 comments Download
A client/third_party/googleapiclient/README.md View 1 chunk +36 lines, -0 lines 0 comments Download
M client/third_party/googleapiclient/README.swarming View 1 chunk +4 lines, -6 lines 0 comments Download
M client/third_party/googleapiclient/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M client/third_party/googleapiclient/discovery_cache/file_cache.py View 1 chunk +1 line, -1 line 0 comments Download
M client/third_party/infra_libs/ts_mon/common/monitors.py View 2 chunks +2 lines, -2 lines 1 comment Download
M client/third_party/oauth2client/README.md View 1 chunk +1 line, -1 line 0 comments Download
M client/third_party/oauth2client/README.swarming View 2 chunks +7 lines, -5 lines 0 comments Download
M client/third_party/oauth2client/__init__.py View 1 chunk +4 lines, -4 lines 0 comments Download
M client/third_party/oauth2client/_openssl_crypt.py View 3 chunks +8 lines, -8 lines 0 comments Download
A client/third_party/oauth2client/_pure_python_crypt.py View 1 chunk +185 lines, -0 lines 0 comments Download
M client/third_party/oauth2client/_pycrypto_crypt.py View 1 chunk +4 lines, -6 lines 0 comments Download
M client/third_party/oauth2client/client.py View 30 chunks +126 lines, -162 lines 0 comments Download
M client/third_party/oauth2client/clientsecrets.py View 1 chunk +3 lines, -2 lines 0 comments Download
A client/third_party/oauth2client/contrib/__init__.py View 1 chunk +6 lines, -0 lines 0 comments Download
A client/third_party/oauth2client/contrib/appengine.py View 1 chunk +928 lines, -0 lines 0 comments Download
A client/third_party/oauth2client/contrib/gce.py View 1 chunk +194 lines, -0 lines 0 comments Download
A + client/third_party/oauth2client/contrib/locked_file.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/third_party/oauth2client/contrib/multistore_file.py View 5 chunks +20 lines, -3 lines 0 comments Download
A + client/third_party/oauth2client/contrib/xsrfutil.py View 1 chunk +0 lines, -1 line 0 comments Download
M client/third_party/oauth2client/crypt.py View 3 chunks +10 lines, -5 lines 0 comments Download
M client/third_party/oauth2client/file.py View 1 chunk +1 line, -16 lines 0 comments Download
D client/third_party/oauth2client/gce.py View 1 chunk +0 lines, -111 lines 0 comments Download
D client/third_party/oauth2client/keyring_storage.py View 1 chunk +0 lines, -114 lines 0 comments Download
D client/third_party/oauth2client/locked_file.py View 1 chunk +0 lines, -387 lines 0 comments Download
D client/third_party/oauth2client/multistore_file.py View 1 chunk +0 lines, -484 lines 0 comments Download
M client/third_party/oauth2client/service_account.py View 1 chunk +399 lines, -69 lines 0 comments Download
M client/third_party/oauth2client/tools.py View 4 chunks +9 lines, -5 lines 0 comments Download
M client/third_party/oauth2client/util.py View 3 chunks +0 lines, -18 lines 0 comments Download
D client/third_party/oauth2client/xsrfutil.py View 1 chunk +0 lines, -107 lines 0 comments Download
M client/utils/oauth.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
M-A Ruel
4 years, 9 months ago (2016-03-07 15:20:12 UTC) #6
Sergey Berezin
Any reason for the upgrade? Does the reason apply to infra.git? I'd rather not "fork" ...
4 years, 9 months ago (2016-03-07 17:41:16 UTC) #8
M-A Ruel
On 2016/03/07 17:41:16, Sergey Berezin wrote: > Any reason for the upgrade? Kevin (cc'ed) explicitly ...
4 years, 9 months ago (2016-03-07 17:51:35 UTC) #9
Sergey Berezin
On 2016/03/07 17:51:35, M-A Ruel wrote: > On 2016/03/07 17:41:16, Sergey Berezin wrote: > > ...
4 years, 9 months ago (2016-03-09 19:38:35 UTC) #10
M-A Ruel
4 years, 9 months ago (2016-03-10 00:37:06 UTC) #11
On 2016/03/09 19:38:35, Sergey Berezin wrote:
> On 2016/03/07 17:51:35, M-A Ruel wrote:
> > On 2016/03/07 17:41:16, Sergey Berezin wrote:
> > > Any reason for the upgrade?
> > 
> > Kevin (cc'ed) explicitly asked me to.
> > 
> > > Does the reason apply to infra.git? I'd rather not
> > > "fork" the vendored code, and modify directly in the upstream. And to keep
> > > ts_mon clean, it may make sense to upgrade infra.git's versions of the
> > libraries
> > > first.
> > > 
> > > I can help with that if you'd like.
> > 
> > Yes, that would be appreciated if you could do it. I'd still want to have
the
> > removal of the version in //appengine/third_party/ once ts_mon gets updated.
> > Thanks.
> 
> Well, the real reason we have two copies is because AppEngine cannot work with
> the versions in client/. It's a pain... I can try experimenting with it again,
> and if they fixed it, maybe we can merge the versions now. It's a bit of a
> project though. Filed http://crbug.com/593426 to track it.

Ok, thanks.

Powered by Google App Engine
This is Rietveld 408576698