Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 1768973002: [debugger] break at each initialization in a multiple var declaration. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] break at each initialization in a multiple var declaration. R=rossberg@chromium.org BUG=v8:4807 LOG=N Committed: https://crrev.com/ee98147ea0d994bcfb0d14d43f490ee828d2426f Cr-Commit-Position: refs/heads/master@{#34531} Committed: https://crrev.com/9113402b53cbd1b51ee199716b5d5806d2a7374f Cr-Commit-Position: refs/heads/master@{#34540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -36 lines) Patch
M src/parsing/pattern-rewriter.cc View 4 chunks +11 lines, -16 lines 0 comments Download
M test/cctest/test-debug.cc View 8 chunks +8 lines, -9 lines 0 comments Download
A test/mjsunit/debug-multiple-var-decl.js View 1 chunk +74 lines, -0 lines 0 comments Download
M test/mjsunit/debug-stepin-accessor-ic.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-stepin-string-template.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/es6/debug-stepnext-for.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/debug-stepin-default-parameters.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/debug-stepin-proxies.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-debug-deopt-while-recompile.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Yang
4 years, 9 months ago (2016-03-07 10:41:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768973002/1
4 years, 9 months ago (2016-03-07 10:44:46 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 11:05:19 UTC) #5
rossberg
lgtm
4 years, 9 months ago (2016-03-07 11:53:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768973002/1
4 years, 9 months ago (2016-03-07 11:57:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 11:59:15 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ee98147ea0d994bcfb0d14d43f490ee828d2426f Cr-Commit-Position: refs/heads/master@{#34531}
4 years, 9 months ago (2016-03-07 12:00:21 UTC) #11
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1770783003/ by machenbach@chromium.org. ...
4 years, 9 months ago (2016-03-07 12:53:16 UTC) #12
Yang
On 2016/03/07 12:53:16, Michael Achenbach wrote: > A revert of this CL (patchset #1 id:1) ...
4 years, 9 months ago (2016-03-07 13:35:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768973002/1
4 years, 9 months ago (2016-03-07 13:36:14 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 13:39:56 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 13:41:25 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9113402b53cbd1b51ee199716b5d5806d2a7374f
Cr-Commit-Position: refs/heads/master@{#34540}

Powered by Google App Engine
This is Rietveld 408576698