Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 1768853002: Match version of idl_parser and WebCore so go.sh can be run from a Dart only enlistment. (Closed)

Created:
4 years, 9 months ago by terry
Modified:
4 years, 9 months ago
Reviewers:
Alan Knight, Jacob
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Match version of idl_parser and WebCore so go.sh can be run from a Dart only enlistment. Needed to pull in the tools/idl_parser code for a Dart enlistment populated during a gclient sync. Added .gitingore to not ignore tools/idl_parse TBR=jacobr@google.com,alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/a552c24089d2102904935dee460f694a317b5a25

Patch Set 1 #

Patch Set 2 : Back to third_party #

Patch Set 3 : Point to the correct idl_parser revision. #

Patch Set 4 : Needs to be in tools directory - new Chromium location. #

Patch Set 5 : Changes to run tools/dom/script/go.sh from both Dart and Dartium enlistments. #

Patch Set 6 : Updated commnet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M DEPS View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
A tools/.gitignore View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/scripts/dartdomgenerator.py View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
terry
4 years, 9 months ago (2016-03-06 23:10:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
a552c24089d2102904935dee460f694a317b5a25 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698