Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 176883020: Remove MediaControls::showVolumeSlider() (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Remove MediaControls::showVolumeSlider() This is a remnant from WebKit when there was a volume slider container that could be shown and hidden. What remains is essentially dead code, because at most it shows the slider when m_mediaController->hasAudio(), but MediaControls::reset() already does that. BUG=341813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168452

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M Source/core/html/shadow/MediaControlElements.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 2 chunks +0 lines, -9 lines 4 comments Download
M Source/core/html/shadow/MediaControls.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
6 years, 9 months ago (2014-03-03 17:13:15 UTC) #1
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/176883020/diff/1/Source/core/html/shadow/MediaControlElements.cpp File Source/core/html/shadow/MediaControlElements.cpp (left): https://codereview.chromium.org/176883020/diff/1/Source/core/html/shadow/MediaControlElements.cpp#oldcode287 Source/core/html/shadow/MediaControlElements.cpp:287: MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement(Document& document, MediaControls* controls) Do we even need this ...
6 years, 9 months ago (2014-03-04 02:06:57 UTC) #2
philipj_slow
https://codereview.chromium.org/176883020/diff/1/Source/core/html/shadow/MediaControlElements.cpp File Source/core/html/shadow/MediaControlElements.cpp (left): https://codereview.chromium.org/176883020/diff/1/Source/core/html/shadow/MediaControlElements.cpp#oldcode287 Source/core/html/shadow/MediaControlElements.cpp:287: MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement(Document& document, MediaControls* controls) On 2014/03/04 02:06:58, acolwell wrote: ...
6 years, 9 months ago (2014-03-04 08:10:15 UTC) #3
acolwell GONE FROM CHROMIUM
lgtm https://codereview.chromium.org/176883020/diff/1/Source/core/html/shadow/MediaControlElements.cpp File Source/core/html/shadow/MediaControlElements.cpp (left): https://codereview.chromium.org/176883020/diff/1/Source/core/html/shadow/MediaControlElements.cpp#oldcode305 Source/core/html/shadow/MediaControlElements.cpp:305: if (event->type() == EventTypeNames::mouseover) We don't need this ...
6 years, 9 months ago (2014-03-04 23:23:17 UTC) #4
philipj_slow
https://codereview.chromium.org/176883020/diff/1/Source/core/html/shadow/MediaControlElements.cpp File Source/core/html/shadow/MediaControlElements.cpp (left): https://codereview.chromium.org/176883020/diff/1/Source/core/html/shadow/MediaControlElements.cpp#oldcode305 Source/core/html/shadow/MediaControlElements.cpp:305: if (event->type() == EventTypeNames::mouseover) On 2014/03/04 23:23:17, acolwell wrote: ...
6 years, 9 months ago (2014-03-05 07:22:15 UTC) #5
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-05 07:23:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/176883020/1
6 years, 9 months ago (2014-03-05 07:24:22 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 08:52:32 UTC) #8
Message was sent while issue was closed.
Change committed as 168452

Powered by Google App Engine
This is Rietveld 408576698