|
|
Created:
6 years, 9 months ago by haraken Modified:
6 years, 9 months ago CC:
blink-reviews, loislo+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, adamk+blink_chromium.org, Inactive, Mikhail Base URL:
svn://svn.chromium.org/blink/trunk Visibility:
Public. |
DescriptionPartially revert r168100
In r168100, I mis-committed an unnecessary change to wtf/ to fix compile failure.
(The wtf/ change became unnecessary because the compile failure was fixed
in https://codereview.chromium.org/182733004/.)
This CL reverts the wtf/ part of r168100.
TBR=tkent
NOTRY=true
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168121
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #
Messages
Total messages: 17 (0 generated)
PTAL
Thanks! Can confirm that this addresses the build problems.
On 2014/02/28 09:43:20, sof wrote: > Thanks! Can confirm that this addresses the build problems. hmm, I don't think the compile failure is not related the getPtr CLs... > ../../third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp:228:12: error: cannot convert 'std::nullptr_t' to 'WebCore::SpeechSynthesisUtterance*' in return > ../../third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp:229:1: error: control reaches end of non-void function [-Werror=return-type] Either way I updated the CL to fix the nullptr issue.
On 2014/02/28 09:56:37, haraken wrote: > On 2014/02/28 09:43:20, sof wrote: > > Thanks! Can confirm that this addresses the build problems. > > hmm, I don't think the compile failure is not related the getPtr CLs... No, that failure has been reverted already in http://crrev.com/184263003
On 2014/02/28 09:58:43, sof wrote: > On 2014/02/28 09:56:37, haraken wrote: > > On 2014/02/28 09:43:20, sof wrote: > > > Thanks! Can confirm that this addresses the build problems. > > > > hmm, I don't think the compile failure is not related the getPtr CLs... > > No, that failure has been reverted already in http://crrev.com/184263003 ah, ok. So do you think that the patch set 1 will work?
On 2014/02/28 09:59:45, haraken wrote: > On 2014/02/28 09:58:43, sof wrote: > > On 2014/02/28 09:56:37, haraken wrote: > > > On 2014/02/28 09:43:20, sof wrote: > > > > Thanks! Can confirm that this addresses the build problems. > > > > > > hmm, I don't think the compile failure is not related the getPtr CLs... > > > > No, that failure has been reverted already in http://crrev.com/184263003 > > ah, ok. So do you think that the patch set 1 will work? Yes, compiles fine with current HEAD :)
On 2014/02/28 10:01:59, sof wrote: > On 2014/02/28 09:59:45, haraken wrote: > > On 2014/02/28 09:58:43, sof wrote: > > > On 2014/02/28 09:56:37, haraken wrote: > > > > On 2014/02/28 09:43:20, sof wrote: > > > > > Thanks! Can confirm that this addresses the build problems. > > > > > > > > hmm, I don't think the compile failure is not related the getPtr CLs... > > > > > > No, that failure has been reverted already in http://crrev.com/184263003 > > > > ah, ok. So do you think that the patch set 1 will work? > > Yes, compiles fine with current HEAD :) Thanks. PTAL for the patch set 3.
Doesn't count, but enable_oilpan=1 lgtm.
Let me land this CL with TBR=tkent, to fix build failures in oilpan bots.
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/176883010/40001
LGTM
The CQ bit was unchecked by haraken@chromium.org
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/176883010/40001
Message was sent while issue was closed.
Change committed as 168121
Message was sent while issue was closed.
lgtm |