Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 176883010: Partially revert r168100 (Closed)

Created:
6 years, 9 months ago by haraken
Modified:
6 years, 9 months ago
CC:
blink-reviews, loislo+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, adamk+blink_chromium.org, Inactive, Mikhail
Visibility:
Public.

Description

Partially revert r168100 In r168100, I mis-committed an unnecessary change to wtf/ to fix compile failure. (The wtf/ change became unnecessary because the compile failure was fixed in https://codereview.chromium.org/182733004/.) This CL reverts the wtf/ part of r168100. TBR=tkent NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168121

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/wtf/GetPtr.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
haraken
PTAL
6 years, 9 months ago (2014-02-28 09:17:46 UTC) #1
sof
Thanks! Can confirm that this addresses the build problems.
6 years, 9 months ago (2014-02-28 09:43:20 UTC) #2
haraken
On 2014/02/28 09:43:20, sof wrote: > Thanks! Can confirm that this addresses the build problems. ...
6 years, 9 months ago (2014-02-28 09:56:37 UTC) #3
sof
On 2014/02/28 09:56:37, haraken wrote: > On 2014/02/28 09:43:20, sof wrote: > > Thanks! Can ...
6 years, 9 months ago (2014-02-28 09:58:43 UTC) #4
haraken
On 2014/02/28 09:58:43, sof wrote: > On 2014/02/28 09:56:37, haraken wrote: > > On 2014/02/28 ...
6 years, 9 months ago (2014-02-28 09:59:45 UTC) #5
sof
On 2014/02/28 09:59:45, haraken wrote: > On 2014/02/28 09:58:43, sof wrote: > > On 2014/02/28 ...
6 years, 9 months ago (2014-02-28 10:01:59 UTC) #6
haraken
On 2014/02/28 10:01:59, sof wrote: > On 2014/02/28 09:59:45, haraken wrote: > > On 2014/02/28 ...
6 years, 9 months ago (2014-02-28 10:03:43 UTC) #7
sof
Doesn't count, but enable_oilpan=1 lgtm.
6 years, 9 months ago (2014-02-28 10:06:25 UTC) #8
haraken
Let me land this CL with TBR=tkent, to fix build failures in oilpan bots.
6 years, 9 months ago (2014-02-28 11:00:51 UTC) #9
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-02-28 11:01:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/176883010/40001
6 years, 9 months ago (2014-02-28 11:01:30 UTC) #11
Erik Corry
LGTM
6 years, 9 months ago (2014-02-28 11:13:58 UTC) #12
haraken
The CQ bit was unchecked by haraken@chromium.org
6 years, 9 months ago (2014-02-28 12:14:34 UTC) #13
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-02-28 12:14:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/176883010/40001
6 years, 9 months ago (2014-02-28 12:14:55 UTC) #15
commit-bot: I haz the power
Change committed as 168121
6 years, 9 months ago (2014-02-28 12:15:11 UTC) #16
tkent
6 years, 9 months ago (2014-03-03 00:53:29 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698