Issue 176883005: Have Element::ensureUniqueElementData() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 176883005: Have Element::ensureUniqueElementData() return a reference (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
adamk

CC:
blink-reviews, ed+blinkwatch_opera.com, krit, sof, eae+blinkwatch, fs, dglazkov+blink, f(malita), adamk+blink_chromium.org, gyuyoung.kim_webkit.org, Inactive, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have Element::ensureUniqueElementData() return a reference Have Element::ensureUniqueElementData() return a reference instead of a pointer as it can never return null. It makes the calling code look safer. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167962

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -23 lines)			Patch
M	Source/core/dom/Attr.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	9 chunks	+17 lines, -17 lines	0 comments	Download
M	Source/core/html/HTMLSelectElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/176883005/1

6 years, 10 months ago (2014-02-26 21:16:17 UTC) #3

Message was sent while issue was closed.

Change committed as 167962

Expand Messages | Collapse Messages