Issue 176883003: Make InstallObserver methods not pure-virtual

Issue 176883003: Make InstallObserver methods not pure-virtual (Closed)

Created:
6 years, 10 months ago by Devlin

Modified:
6 years, 9 months ago

Reviewers:
benwells

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, felt, tfarina, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Make InstallObserver methods not pure-virtual A bunch of InstallTracker implementers use only a subset of the InstallTracker methods, but all these methods are pure virtual. Clean this up so that classes only need to implement what they actually use. Broken from https://codereview.chromium.org/175263003/ at Kalman's request. BUG=347166 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253741

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -138 lines)			Patch
M	chrome/browser/extensions/activity_log/activity_log.h	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/extensions/extension_service_unittest.cc	View	1 chunk	+0 lines, -27 lines	0 comments	Download
M	chrome/browser/extensions/install_observer.h	View	1 chunk	+24 lines, -11 lines	0 comments	Download
M	chrome/browser/extensions/install_observer.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/app_list/extension_app_model_builder.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/app_list/extension_app_model_builder.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/app_list/recommended_apps.h	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/app_list/recommended_apps.cc	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/app_list/search/app_result.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/app_list/search/app_result.cc	View	2 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/app_list/search/webstore/webstore_result.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/app_list/search/webstore/webstore_result.cc	View	3 chunks	+0 lines, -18 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/176883003/10001

6 years, 10 months ago (2014-02-26 22:50:14 UTC) #4

Message was sent while issue was closed.

Change committed as 253741