Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: src/IceTargetLoweringARM32.h

Issue 1768823002: Subzero. ARM32. Fix bugs uncovered by scons tests. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fixes build break. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceTargetLoweringARM32.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringARM32.h
diff --git a/src/IceTargetLoweringARM32.h b/src/IceTargetLoweringARM32.h
index f3adce7c43346547bed1fde8387afb26d2b599a3..36f5cfdfa1fbb7eeaed2b9fc590c33992a989da8 100644
--- a/src/IceTargetLoweringARM32.h
+++ b/src/IceTargetLoweringARM32.h
@@ -785,18 +785,13 @@ protected:
CondARM32::Cond Pred = CondARM32::AL) {
Context.insert<InstARM32Str>(Value, Addr, Pred);
}
- void _strex(Variable *Dest, Variable *Value, OperandARM32Mem *Addr,
- CondARM32::Cond Pred = CondARM32::AL) {
- // strex requires Dest to be a register other than Value or Addr. This
- // restriction is cleanly represented by adding an "early" definition of
- // Dest (or a latter use of all the sources.)
- Context.insert<InstFakeDef>(Dest);
+ InstARM32Strex *_strex(Variable *Dest, Variable *Value, OperandARM32Mem *Addr,
+ CondARM32::Cond Pred = CondARM32::AL) {
if (auto *Value64 = llvm::dyn_cast<Variable64On32>(Value)) {
Context.insert<InstFakeUse>(Value64->getLo());
Context.insert<InstFakeUse>(Value64->getHi());
}
- auto *Instr = Context.insert<InstARM32Strex>(Dest, Value, Addr, Pred);
- Instr->setDestRedefined();
+ return Context.insert<InstARM32Strex>(Dest, Value, Addr, Pred);
}
void _sub(Variable *Dest, Variable *Src0, Operand *Src1,
CondARM32::Cond Pred = CondARM32::AL) {
« no previous file with comments | « no previous file | src/IceTargetLoweringARM32.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698