apps/apps.gypi - Issue 176873016: [AppShell] Remove chrome_100_percent.pak dependancy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/apps.gypi

Issue 176873016: [AppShell] Remove chrome_100_percent.pak dependancy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address tfarina's comment Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: apps/apps.gypi

diff --git a/apps/apps.gypi b/apps/apps.gypi

index e0031fb090b58eae5c2bebc148648d224aaef17f..acf48a58bf25fc0e8a49cca76429888e06e2edbe 100644

--- a/apps/apps.gypi

+++ b/apps/apps.gypi

@@ -103,11 +103,15 @@

'target_name': 'app_shell_pak',

'type': 'none',

'dependencies': [

- # Need dev-tools related resources in shell_resources.pak and devtools_resources.pak.

+ # Need dev-tools related resources in shell_resources.pak and

+ # devtools_resources.pak.

'../content/content_shell_and_tests.gyp:generate_content_shell_resources',

'../content/browser/devtools/devtools_resources.gyp:devtools_resources',

# Need features JSON files in common_resources.pak.

'chrome_resources.gyp:chrome_resources',

+ # Need view::widget resources(such as minimize button, maximize

+ # button, close button) in chrome_100_percent.pak.

+ 'chrome_resources.gyp:packed_resources',

tony 2014/03/03 18:30:30 Rather than depending on the target in chrome, you

'variables': {

'repack_path': '<(DEPTH)/tools/grit/grit/format/repack.py',

« no previous file with comments | « no previous file | no next file » | no next file with comments »