Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 176873016: [AppShell] Remove chrome_100_percent.pak dependancy. (Closed)

Created:
6 years, 9 months ago by Haojian Wu
Modified:
6 years, 9 months ago
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org, Yoyo Zhou
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[App Shell] Remove chrome_100_percent.pak dependancy. Now app::ShellMainDelegate initializes with chrome_100_percent.pak by default. This patch is to remove this dependancy by add all chrome-specific resources to app_shell.pak. BUG=348484 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255830

Patch Set 1 #

Patch Set 2 : address tfarina's comment #

Total comments: 2

Patch Set 3 : update #

Total comments: 2

Patch Set 4 : update #

Total comments: 3

Patch Set 5 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M apps/apps.gypi View 1 2 3 4 2 chunks +20 lines, -5 lines 0 comments Download
M apps/shell/app/shell_main_delegate.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Haojian Wu
Please review it. Thanks.
6 years, 9 months ago (2014-03-03 06:04:15 UTC) #1
tfarina
Could you specify in the comment what you need it for? Btw, it is very ...
6 years, 9 months ago (2014-03-03 16:05:49 UTC) #2
tony
https://codereview.chromium.org/176873016/diff/20001/apps/apps.gypi File apps/apps.gypi (right): https://codereview.chromium.org/176873016/diff/20001/apps/apps.gypi#newcode114 apps/apps.gypi:114: 'chrome_resources.gyp:packed_resources', Rather than depending on the target in chrome, ...
6 years, 9 months ago (2014-03-03 18:30:29 UTC) #3
Haojian Wu
On 2014/03/03 18:30:29, tony wrote: > https://codereview.chromium.org/176873016/diff/20001/apps/apps.gypi > File apps/apps.gypi (right): > > https://codereview.chromium.org/176873016/diff/20001/apps/apps.gypi#newcode114 > ...
6 years, 9 months ago (2014-03-05 10:51:06 UTC) #4
tony
https://codereview.chromium.org/176873016/diff/40001/apps/apps.gypi File apps/apps.gypi (right): https://codereview.chromium.org/176873016/diff/40001/apps/apps.gypi#newcode130 apps/apps.gypi:130: '<(SHARED_INTERMEDIATE_DIR)/chrome/theme_resources_100_percent.pak', Does app shell really need strings from generated_resources ...
6 years, 9 months ago (2014-03-05 18:08:44 UTC) #5
James Cook
On 2014/03/05 18:08:44, tony wrote: > https://codereview.chromium.org/176873016/diff/40001/apps/apps.gypi > File apps/apps.gypi (right): > > https://codereview.chromium.org/176873016/diff/40001/apps/apps.gypi#newcode130 > ...
6 years, 9 months ago (2014-03-05 18:13:17 UTC) #6
Haojian Wu
https://codereview.chromium.org/176873016/diff/40001/apps/apps.gypi File apps/apps.gypi (right): https://codereview.chromium.org/176873016/diff/40001/apps/apps.gypi#newcode130 apps/apps.gypi:130: '<(SHARED_INTERMEDIATE_DIR)/chrome/theme_resources_100_percent.pak', On 2014/03/05 18:08:44, tony wrote: > Does app ...
6 years, 9 months ago (2014-03-06 04:37:16 UTC) #7
James Cook
LGTM but please sort things out with Tony before committing.
6 years, 9 months ago (2014-03-06 17:37:25 UTC) #8
tony
On 2014/03/06 04:37:16, Haojian Wu wrote: > https://codereview.chromium.org/176873016/diff/40001/apps/apps.gypi > File apps/apps.gypi (right): > > https://codereview.chromium.org/176873016/diff/40001/apps/apps.gypi#newcode130 ...
6 years, 9 months ago (2014-03-06 17:59:13 UTC) #9
Haojian Wu
https://codereview.chromium.org/176873016/diff/60001/apps/apps.gypi File apps/apps.gypi (right): https://codereview.chromium.org/176873016/diff/60001/apps/apps.gypi#newcode130 apps/apps.gypi:130: # theme_resources_100_percent.pak. james@, please check whether the TODO is ...
6 years, 9 months ago (2014-03-07 11:20:21 UTC) #10
James Cook
LGTM https://codereview.chromium.org/176873016/diff/60001/apps/apps.gypi File apps/apps.gypi (right): https://codereview.chromium.org/176873016/diff/60001/apps/apps.gypi#newcode128 apps/apps.gypi:128: # TODO(Haojian): extra the extension/app related reousrces nit: ...
6 years, 9 months ago (2014-03-07 17:40:09 UTC) #11
Haojian Wu
The CQ bit was checked by hokein.wu@gmail.com
6 years, 9 months ago (2014-03-08 01:57:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/176873016/80001
6 years, 9 months ago (2014-03-08 11:13:52 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 12:56:23 UTC) #14
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=157462
6 years, 9 months ago (2014-03-08 12:56:24 UTC) #15
Haojian Wu
The CQ bit was checked by hokein.wu@gmail.com
6 years, 9 months ago (2014-03-08 13:22:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/176873016/80001
6 years, 9 months ago (2014-03-08 13:23:17 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:15:27 UTC) #18
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234377
6 years, 9 months ago (2014-03-08 14:15:28 UTC) #19
Haojian Wu
The CQ bit was checked by hokein.wu@gmail.com
6 years, 9 months ago (2014-03-09 06:02:52 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/176873016/80001
6 years, 9 months ago (2014-03-09 06:03:12 UTC) #21
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 06:21:04 UTC) #22
Message was sent while issue was closed.
Change committed as 255830

Powered by Google App Engine
This is Rietveld 408576698